From owner-freebsd-bugs@FreeBSD.ORG  Tue Dec  9 05:15:19 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 89FF816A504; Tue,  9 Dec 2003 05:15:19 -0800 (PST)
Received: from comp.chem.msu.su (comp-ext.chem.msu.su [158.250.32.157])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EBF1843D13; Tue,  9 Dec 2003 05:15:02 -0800 (PST)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.12.3p3/8.12.3) with ESMTP id hB9DEgdK096283;
	Tue, 9 Dec 2003 16:14:42 +0300 (MSK)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.12.3p3/8.12.3/Submit) id hB9DEfAn096282;
	Tue, 9 Dec 2003 16:14:41 +0300 (MSK)
	(envelope-from yar)
Date: Tue, 9 Dec 2003 16:14:41 +0300
From: Yar Tikhiy <yar@FreeBSD.ORG>
To: Gleb Smirnoff <glebius@cell.sick.ru>,
	FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG
Message-ID: <20031209131441.GB95449@comp.chem.msu.su>
References: <200302042232.h14MWLGj005760@virgin.v.gz.ru>
	<20031209090837.GE28861@cell.sick.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031209090837.GE28861@cell.sick.ru>
User-Agent: Mutt/1.5.3i
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays
	in it forever
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Dec 2003 13:15:19 -0000

I would rather change the name of the variable "nonstandard"
to "pppoe_mode", not "standard", because lines like this one:

	standard = PPPOE_NONSTANDARD;

give me a schizoid feeling :-)

I also believe you should not omit the "freebsd-gnats-submit@freebsd.org"
address from the list of recipients when sending a follow-up to a PR, or
else GNATS will not be able to add your follow-up to the audit trail.

-- 
Yar