From nobody Mon Jul 27 19:14:50 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h87Zg03xSz6nQCq for ; Mon, 27 Jul 2026 19:14:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h87Zf2Fmrz3fCC for ; Mon, 27 Jul 2026 19:14:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785179690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dJOXEKCobWuVYBXs8Wqjx1AZf1yCq4/xzPomW17QnqU=; b=mKw7B7KwFnrRFEE5RgK5rGtfGHL8DQpAPnENZlx7pea/SK9GDLTrBiCLpxTGA4Cg1CBtHG wQAHEQCY890Le/qcXkScMBspQgNX/SpA0M4qS4/F2JmnvK2rVa8FALXLwaZexrJMeQ0p3w 0++hL7Fm/GenAx+stBjZFZvUMmuSmaa+d1slXrY0yPj9DmDcDrsDUGUJ+mGtMoXiPsMjJs CbGN2Ta0tqdBTdauQOv3t0QEz6Rpp1cbTlCfiI//OByC/TLX5BLNmiE4SjIl8Bt+paW4xu MPgy7H6qwP3x1Ej3OQyrD0RW4CLG8dBUHo6FB6/PeM2f7SgaEah48DtjTREyJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785179690; a=rsa-sha256; cv=none; b=xf56054kjuJXc/ek38wCkwGWHw/UdB5RRto5hzSKGSItMGx53WMREyNZKrYW2umXSiVtqW 5Q0266khXhp/vPvQ7yb5f1s0Lo9k2zD1j2qI0DxFrvH1aWtuS5v0PQjKNhy5l2R8YPLb0N e8/egFKd9mbeZfYNIpRMGZ461mzzyIuK7A1NM8hpEqUZ+OskMWeVwR0cU0AjStwWHwHBKd eC9a3wv8xmle+m6E+u3zoRzEbZ9Wtzr7exzqUtZz03AJBWGCi+ZQKPVzqn70qr7dVLNFMC 9GOAvfVZefX396K4BytRpdXZiz14hoz6EENGdLdX+B5p03pYEWHl1Y034UrsSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785179690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dJOXEKCobWuVYBXs8Wqjx1AZf1yCq4/xzPomW17QnqU=; b=aTew/x5yQLwY2bxLsnN0ygZtOuAKpCAwb8qi0thl263kRZqhnGZaJWa5Vu5kR9H1No7LLE CQS6zRg7tqP0Wzy4wYMweOdxbCQ6Z6/whRE+yj3JB1uGBOGNWvnJTYsNUmxPLh6k1UQe9T mEG2f6TTCvC07wgytJyVMskr9gUiE/3hu4nihtJOep8VEDf5WymCRrgjhpp7Qon4ZNPxed QkyoNZIi9ZwNVnHDgqgAz8FQX45GOQz27pzpQuaVoLO0jjTGLoqrC54S9UIzqjiMgvWJYZ Ohipsg6T3/tyWzqmwxrtICIqZCGcqjGyWkXfjyzlXWxGr8JBUg3G6bOVKjxaCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h87Zf1G2zz1Krq for ; Mon, 27 Jul 2026 19:14:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37d40 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Jul 2026 19:14:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: ee4316c0c357 - stable/15 - vfs: Fix resource leaks in kern_symlinkat() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ee4316c0c3575948bb6d8eb654b07932ba51736f Auto-Submitted: auto-generated Date: Mon, 27 Jul 2026 19:14:50 +0000 Message-Id: <6a67ae2a.37d40.565debff@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ee4316c0c3575948bb6d8eb654b07932ba51736f commit ee4316c0c3575948bb6d8eb654b07932ba51736f Author: Mark Johnston AuthorDate: 2026-07-06 15:42:52 +0000 Commit: Mark Johnston CommitDate: 2026-07-27 17:34:31 +0000 vfs: Fix resource leaks in kern_symlinkat() Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes") Reported by: Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li, and Ke Xu from Tsinghua University using GLM-5.2 from Z.ai Reviewed by: rmacklem, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58053 (cherry picked from commit 58c73727d6e49de1fc4f4bc90621146cae8db2bc) --- sys/kern/vfs_syscalls.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index a6f513b719ba..c27671bcfc28 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1882,7 +1882,7 @@ restart: } if ((vn_irflag_read(nd.ni_dvp) & VIRF_NAMEDDIR) != 0) { error = EINVAL; - goto out; + goto out2; } VATTR_NULL(&vattr); vattr.va_mode = ACCESSPERMS &~ td->td_proc->p_pd->pd_cmask; @@ -1894,9 +1894,7 @@ restart: goto out2; #endif error = VOP_SYMLINK(nd.ni_dvp, &nd.ni_vp, &nd.ni_cnd, &vattr, syspath); -#ifdef MAC out2: -#endif VOP_VPUT_PAIR(nd.ni_dvp, error == 0 ? &nd.ni_vp : NULL, true); vn_finished_write(mp); NDFREE_PNBUF(&nd);