From owner-svn-src-head@FreeBSD.ORG Mon Feb 3 20:07:44 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D6FF8526; Mon, 3 Feb 2014 20:07:44 +0000 (UTC) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A80FE1E41; Mon, 3 Feb 2014 20:07:44 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1WAPnz-000Hgw-3X; Mon, 03 Feb 2014 20:07:43 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s13K7eDe063456; Mon, 3 Feb 2014 13:07:40 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+M3UDiJTkOuchD49Li+y+A Subject: Re: svn commit: r261424 - head/sys/dev/mmc From: Ian Lepore To: John-Mark Gurney In-Reply-To: <20140203170330.GC89104@funkthat.com> References: <201402030256.s132uNjk086555@svn.freebsd.org> <20140203170330.GC89104@funkthat.com> Content-Type: text/plain; charset="us-ascii" Date: Mon, 03 Feb 2014 13:07:39 -0700 Message-ID: <1391458059.13026.96.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 20:07:44 -0000 On Mon, 2014-02-03 at 09:03 -0800, John-Mark Gurney wrote: > Ian Lepore wrote this message on Mon, Feb 03, 2014 at 02:56 +0000: > > Author: ian > > Date: Mon Feb 3 02:56:23 2014 > > New Revision: 261424 > > URL: http://svnweb.freebsd.org/changeset/base/261424 > > > > Log: > > Sort the list. > > > > Modified: > > head/sys/dev/mmc/mmc.c > > > > Modified: head/sys/dev/mmc/mmc.c > > ============================================================================== > > --- head/sys/dev/mmc/mmc.c Mon Feb 3 02:52:07 2014 (r261423) > > +++ head/sys/dev/mmc/mmc.c Mon Feb 3 02:56:23 2014 (r261424) > > @@ -1756,10 +1756,11 @@ static driver_t mmc_driver = { > > }; > > static devclass_t mmc_devclass; > > > > -DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, at91_mci, mmc_driver, mmc_devclass, NULL, NULL); > > -DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_bcm, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_fdt, mmc_driver, mmc_devclass, NULL, NULL); > > -DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > > DRIVER_MODULE(mmc, sdhci_imx, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > > +DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > > + > > Is there a reason we don't make mmc_driver/mmc_devclass global and put > all of these defines in their respective file instead of poluting an MI > file w/ MD info? > I don't think that's an option. Part of what that macro does is create metadata that says "this module contains a driver that is a child of bus " and I think for that to work right, it has to be in the module itself, not elsewhere (at least in the .ko case; maybe it doesn't matter when it's compiled into the kernel). -- Ian