From owner-cvs-sys  Sun Mar  8 10:38:11 1998
Return-Path: <owner-cvs-sys>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id KAA23215
          for cvs-sys-outgoing; Sun, 8 Mar 1998 10:38:11 -0800 (PST)
          (envelope-from owner-cvs-sys)
Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA23083;
          Sun, 8 Mar 1998 10:37:57 -0800 (PST)
          (envelope-from toor@dyson.iquest.net)
Received: (from root@localhost)
	by dyson.iquest.net (8.8.8/8.8.8) id NAA00266;
	Sun, 8 Mar 1998 13:37:49 -0500 (EST)
	(envelope-from toor)
From: "John S. Dyson" <toor@dyson.iquest.net>
Message-Id: <199803081837.NAA00266@dyson.iquest.net>
Subject: Re: cvs commit: src/sys/miscfs/specfs spec_vnops.c
In-Reply-To: <199803081829.FAA15021@godzilla.zeta.org.au> from Bruce Evans at "Mar 9, 98 05:29:06 am"
To: bde@zeta.org.au (Bruce Evans)
Date: Sun, 8 Mar 1998 13:37:49 -0500 (EST)
Cc: dyson@FreeBSD.ORG, gibbs@plutotech.com, cvs-all@FreeBSD.ORG,
        cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL32 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Bruce Evans said:
> >>  Modified files:
> >>    sys/miscfs/specfs    spec_vnops.c 
> >>  Log:
> >>  Initialize b_resid, and also print out better diagnostics on I/O
> >>  errors.  This will allow for better tracking of user error reports.
> >
> >What is b_resid initialized to?  CAM only touches b_resid when an error
> >occurs or there is a residual, so I'm hoping it's initialized to 0.
> >I think that other portions of the tree also expect it to be zero.
> 
> It is initialized to 0.  This is bogus since it is already initialized to
> 0 (in initpbuf()).  It might be useful to initialize it to a bad value to
> punish portions of the tree expect it to be zero.  It used to be abused
> as the cylinder number for disksort(), so old code won't expect it to be
> initialized.
> 
We don't need to punish right now.  Let's just try to stabilize, and where
we have weaknesses, let's put appropriate diagnostics in the code.

-- 
John                  | Never try to teach a pig to sing,
dyson@freebsd.org     | it just makes you look stupid,
jdyson@nc.com         | and it irritates the pig.