From owner-freebsd-bugs  Tue Sep  4  3:50:24 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 9391937B406
	for <freebsd-bugs@hub.freebsd.org>; Tue,  4 Sep 2001 03:50:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f84Ao1m46006;
	Tue, 4 Sep 2001 03:50:01 -0700 (PDT)
	(envelope-from gnats)
Date: Tue, 4 Sep 2001 03:50:01 -0700 (PDT)
Message-Id: <200109041050.f84Ao1m46006@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Peter Pentchev <roam@ringlet.net>
Subject: Re: bin/30304: [PATCH] PAM authentication for uucpd
Reply-To: Peter Pentchev <roam@ringlet.net>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/30304; it has been noted by GNATS.

From: Peter Pentchev <roam@ringlet.net>
To: Volker Stolz <vs@foldr.org>
Cc: FreeBSD-gnats-submit@freebsd.org, markm@freebsd.org
Subject: Re: bin/30304: [PATCH] PAM authentication for uucpd
Date: Tue, 4 Sep 2001 13:40:32 +0300

 On Tue, Sep 04, 2001 at 12:27:13PM +0200, Volker Stolz wrote:
 > 
 > >Number:         30304
 > >Category:       bin
 > >Synopsis:       [PATCH] PAM authentication for uucpd
 > >Originator:     Volker Stolz
 > >Release:        FreeBSD 4.4-RC i386
 > >Organization:
 > Lehrstuhl für Informatik II
 > >Environment:
 > System: FreeBSD monster.ikea.net 4.4-RC FreeBSD 4.4-RC #0: Thu Aug 30 19:27:52 CEST 2001 vs@monster.ikea.net:/opt/obj/opt/src/sys/MONSTER i386
 > 
 > 
 > >Description:
 > 
 > uucpd only uses getpwnam() for authentication. This patch adds PAM auth
 > via facility "uucpd" in /etc/pam.conf
 [snip]
 > 
 > >Fix:
 > http://www-i2.informatik.rwth-aachen.de/~stolz/FreeBSD/uucpd-pam.patch
 
 Great work!
 I think, however, that this fix would get quite a bit smaller if you
 re-indented your code back to the style(9) eight-character indent :)
 A large part of the doit() diff is only due to 8 -> 2 character indents..
 
 G'luck,
 Peter
 
 -- 
 This sentence contains exactly threee erors.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message