From owner-svn-ports-all@freebsd.org Fri Feb 16 15:42:18 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1352BF1EDF8; Fri, 16 Feb 2018 15:42:18 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA92A80C8E; Fri, 16 Feb 2018 15:42:16 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9F389209AD; Fri, 16 Feb 2018 10:42:15 -0500 (EST) Received: from web4 ([10.202.2.214]) by compute3.internal (MEProxy); Fri, 16 Feb 2018 10:42:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=qP+nxi 8oIlJWVx03w6bugmFPpIoGnZ4tz99wzH/+hN4=; b=Gz6EqNUKuG8+xHgpSmxyZm aTvqc7nZmQBwcJ/OPK+Pws6jMB9RpBmfUdPdZjJqYoRo4lo2BfRD4P2bc9ilw6ag sfLW9xXS8u+8Wu1xwbEtV7gAOBMV1uxW2Dl0O37Ie95kRaieJEvVk6iC6uoJ2Zfm 89HIxtcOU8oMNBlXP7JKH3hkWz3Nw8uV8ldnmG82x/OLh0aszjbJ0oea70z/yJwP fVQi4DuPxwaAUz+H++oiGY8IP/CV3FZWIcHRsgC6qTb30wrDqd3m6neByCi0XZzB sFE3DWXSh1t+nvQEJaAv7w2bJ+2BKvGJYWXwxGYlfql0m9CRGNkkRROgvUIqWW2Q == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 7EE60BA43B; Fri, 16 Feb 2018 10:42:15 -0500 (EST) Message-Id: <1518795735.3761657.1273209560.03AB7B50@webmail.messagingengine.com> From: Mark Felder To: Tijl Coosemans Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-1b99b2df In-Reply-To: <20180214141840.583d247a@kalimero.tijl.coosemans.org> Subject: Re: svn commit: r461746 - head/security/ca_root_nss References: <201802132045.w1DKjdOQ093642@repo.freebsd.org> <20180214141840.583d247a@kalimero.tijl.coosemans.org> Date: Fri, 16 Feb 2018 09:42:15 -0600 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 15:42:18 -0000 On Wed, Feb 14, 2018, at 07:18, Tijl Coosemans wrote: > On Tue, 13 Feb 2018 20:45:39 +0000 (UTC) Mark Felder wrote: > > Author: feld > > Date: Tue Feb 13 20:45:38 2018 > > New Revision: 461746 > > URL: https://svnweb.freebsd.org/changeset/ports/461746 > > > > Log: > > security/ca_root_nss: Add post-exec script to automatically sync to mono's > > certificate store > > > > PR: 225357 > > > > Modified: > > head/security/ca_root_nss/Makefile > > head/security/ca_root_nss/pkg-plist > > > > Modified: head/security/ca_root_nss/Makefile > > ============================================================================== > > --- head/security/ca_root_nss/Makefile Tue Feb 13 20:25:50 2018 (r461745) > > +++ head/security/ca_root_nss/Makefile Tue Feb 13 20:45:38 2018 (r461746) > > @@ -2,6 +2,7 @@ > > > > PORTNAME= ca_root_nss > > PORTVERSION= ${VERSION_NSS} > > +PORTREVISION= 1 > > CATEGORIES= security > > MASTER_SITES= MOZILLA/security/nss/releases/${DISTNAME:tu:C/[-.]/_/g}_RTM/src > > DISTNAME= nss-${VERSION_NSS}${NSS_SUFFIX} > > > > Modified: head/security/ca_root_nss/pkg-plist > > ============================================================================== > > --- head/security/ca_root_nss/pkg-plist Tue Feb 13 20:25:50 2018 (r461745) > > +++ head/security/ca_root_nss/pkg-plist Tue Feb 13 20:45:38 2018 (r461746) > > @@ -3,3 +3,4 @@ > > @sample openssl/cert.pem.sample > > %%ETCSYMLINK%%/etc/ssl/cert.pem > > %%ETCSYMLINK%%@dir /etc/ssl > > +@postexec [ -x %%LOCALBASE%%/bin/cert-sync ] && %%LOCALBASE%%/bin/cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt > > This command returns an error if the executable doesn't exist. You > should invert the logic: > > @postexec [ ! -x %%LOCALBASE%%/bin/cert-sync ] || %%LOCALBASE%%/bin/ > cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt > What did the error look like? I wasn't seeing anything in my testport runs. I intentionally reversed the logic from the original submitter for readability and now feel like a fool. :-) -- Mark Felder ports-secteam & portmgr member feld@FreeBSD.org