From owner-freebsd-testing@FreeBSD.ORG Tue Oct 29 21:22:40 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0FB8C4FE for ; Tue, 29 Oct 2013 21:22:40 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe005.messaging.microsoft.com [213.199.154.208]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6CE0128F2 for ; Tue, 29 Oct 2013 21:22:39 +0000 (UTC) Received: from mail18-am1-R.bigfish.com (10.3.201.227) by AM1EHSOBE015.bigfish.com (10.3.207.137) with Microsoft SMTP Server id 14.1.225.22; Tue, 29 Oct 2013 20:37:09 +0000 Received: from mail18-am1 (localhost [127.0.0.1]) by mail18-am1-R.bigfish.com (Postfix) with ESMTP id F3D5630006A; Tue, 29 Oct 2013 20:37:08 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.224.53; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF01-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 3 X-BigFish: VPS3(zzzz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h1082kzz8275ch17326ah1de097h186068hz2fh2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h1155h) Received-SPF: pass (mail18-am1: domain of juniper.net designates 66.129.224.53 as permitted sender) client-ip=66.129.224.53; envelope-from=sjg@juniper.net; helo=P-EMF01-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail18-am1 (localhost.localdomain [127.0.0.1]) by mail18-am1 (MessageSwitch) id 1383079027487551_32023; Tue, 29 Oct 2013 20:37:07 +0000 (UTC) Received: from AM1EHSMHS003.bigfish.com (unknown [10.3.201.252]) by mail18-am1.bigfish.com (Postfix) with ESMTP id 6FC84E00DF; Tue, 29 Oct 2013 20:37:07 +0000 (UTC) Received: from P-EMF01-SAC.jnpr.net (66.129.224.53) by AM1EHSMHS003.bigfish.com (10.3.207.103) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 29 Oct 2013 20:37:06 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF01-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Tue, 29 Oct 2013 13:37:05 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id r9TKawL05029; Tue, 29 Oct 2013 13:36:59 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 75BF35807E; Tue, 29 Oct 2013 13:36:58 -0700 (PDT) To: Julio Merino Subject: Re: Plugging ATF tests into the build and other cleanups In-Reply-To: References: Comments: In-reply-to: Julio Merino message dated "Sun, 27 Oct 2013 18:12:12 -0400." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Tue, 29 Oct 2013 13:36:58 -0700 Message-ID: <20131029203658.75BF35807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-testing@freebsd.org, Rui Paulo , sjg@juniper.net X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2013 21:22:40 -0000 On Sun, 27 Oct 2013 18:12:12 -0400, Julio Merino writes: >The one concern I have here is having to keep track of all tests in >tools/build/mk/OptionalObsoleteFiles.inc so that setting >WITHOUT_TESTS=no cleans up /usr/tests. This will be a pain to maintain Yes. >and a sure source of inconsistencies. If we could special-case this to >make it more automatic, do you have any suggestions? Iff ATF/Kyua were the only thing populating /usr/tests/ you could just rm -rf that dir, but that's not how delete-old-* works else KYUAFILES!= cd $DESTDIR/ && find usr/tests -name Kyuafile OLD_DIRS+= ${KYUAFILES:H} would be all you'd need. You can't even do OLD_FILES+= ${KYUAFILES:H}/* It could be that a new delete-old- target might be useful, >As usual: http://portal.meroh.net/~jmmv/freebsd-testing/ remove-without-atf.diff looks ok - assuming folk are ok with s,ATF,TESTS, freebsd-testing/recurse-subdir.diff I'm not so crazy about. What's wrong with requiring folk to set TESTS_SUBDIR[S] ? freebsd-testing/move-kyuafiles.diff I'm also not crazy about this one (the change to lib/Makefile) What is the expected use? and why can't everything that is needed be done within the context of the individual lib/*/tests/ dir? That's how we are doing it. build-atf-tests.diff FWIW I prefer ${.CURDIR:H:H} etc rather than ${.CURDIR}/../.. makes for much neater paths (also bit quicker on nfs) It would be nice to be able to rely on SRCTOP being correctly set (easy with bmake, have to think about fmake...) ATF_SRC = ${SRCTOP}/contrib/atf could then be set on one place but otherwise ok.