From owner-cvs-src@FreeBSD.ORG Tue Feb 17 03:11:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E403D16A4CE; Tue, 17 Feb 2004 03:11:10 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E02AC43D2F; Tue, 17 Feb 2004 03:11:10 -0800 (PST) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i1HBBAGe093343; Tue, 17 Feb 2004 03:11:10 -0800 (PST) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i1HBBAZ5093340; Tue, 17 Feb 2004 03:11:10 -0800 (PST) (envelope-from bde) Message-Id: <200402171111.i1HBBAZ5093340@repoman.freebsd.org> From: Bruce Evans Date: Tue, 17 Feb 2004 03:11:10 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys msgbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2004 11:11:11 -0000 bde 2004/02/17 03:11:10 PST FreeBSD src repository Modified files: sys/sys msgbuf.h Log: Backed out previous commit since it just causes panics unless a special value for MSGBUF_SIZE is configured. MSGBUF_SIZE = (32768 * bootverbose ? 2 : 1) is always 1 or 2, so there is not enough space in the buffer for metadata, and blindly using the nonexistent space tends to cause fatal pagefaults. I think MSGBUF_SIZE = (32768 * (bootverbose ? 2 : 1)) would be always 32768 since bootverbose is only statically initialized to 0 early when MSGBUF_SIZE is used. MSGBUF_SIZE = (32768 * ((boothowto & RB_VERBOSE) ? 2 : 1)) should work, but this belongs in even less than previous versions. MSGBUF_SIZE shouldn't be a macro. Revision Changes Path 1.23 +1 -1 src/sys/sys/msgbuf.h