From nobody Fri Aug 7 14:02:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hGm7364GYz6n7sC for ; Fri, 07 Aug 2026 14:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hGm732dFJz3MpJ for ; Fri, 07 Aug 2026 14:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786111343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VAmQelqtlqOybkQgjo9TEkNEyF7EGt/0SKF0RHabH0k=; b=baZzstMAEtso028CvGZNYLrQlhEp9muYsrZM1AQjLhFVqWEIQ5Q+jWL8yptfQj3tNiHorh SY/msQkgNcGxXO3QqgTk5IUlK8DM7IR7YhqdLOauQSCLaHmSd96sb8dx9J8sCwPQliToyH Qnt2ErIBSso1mrPCby6G6h0LXqQIL6iEM6tR18+NvM7cQsCxpdFE/FXWDVsacgejR9Cus5 QAi+lkH7XT1PYAnlZO4HCm0AggOv12b8rX+H9fbliC/5+CpKPGxtvBvc2SEovnW++DLjgG gJVixby+OcQhP/EWNGVyje/vAAVTWeRLAhQ/9nEJ0GyAK88qN/tQU2CiH+itEg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786111343; a=rsa-sha256; cv=none; b=G6WMiA+ed3Z5dJ+ZRL4oTBC5qhY7pkzZjnyn2WEhUxRDV6oWZjFIsvFJDfTIReWPiKd44u 2QG93SGnKr5BtR/0DBkOuqlLXGmwZxJbiGux/ilXwBaiaLePoJ3z21jE4jvMpBkYtKxVms N6NSPZd2m8pBcex6vDJMKApGghZwfwk4ScZINQI4sAaPfNWjFu6ozWJbu7lX9zodaZXvJ+ BQkvcf1KO6x/T5IC8guAlEeCDGtfiefhp5xmu9hFETPJfE/ah+oFykKkLUgtnjQQWdMeFC 4BBLqX4rnIsOq/245YqTuL2djmIEwaoL+mfzMekBhodlVWuFGkVPNbIV7mop9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786111343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VAmQelqtlqOybkQgjo9TEkNEyF7EGt/0SKF0RHabH0k=; b=rtNUwKDSWaUolt0kyiFwM0UBZStW0Lf0FfaDbVdUORvIrSvR1ccKWohoqpvra5iLcNcWgX ODPBksRzCh5IGrSak+olpdeyf5B5aulFly7JE0KLQ0RjSI/FFUURj1i1t1j8JjL9b3dUWl HpLbytNL/B3ORw08M+qDlAU8fBEqWXarMR5HN63TPOfd1ZvPTbLWf/K+csqUVODyng3LVn nM8kZA8wqBonMQ7xVlnvOIcU08PRbTagS/AjJ95ei0YDvHkLIik43etsaS2xC8i4CwEX/8 5G/MC1qUTsFUctm/pqQY5n8uM1Dn0MbSFl/ltmFPSReJfnr9uKAhQ6bXjaRT6Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hGm731F6dz192M for ; Fri, 07 Aug 2026 14:02:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 43380 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 07 Aug 2026 14:02:17 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 545779a99290 - main - ixgbe: Re-enable the SFP laser during initialization List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 545779a99290b7b7d94dece6c096ce230be91ff9 Auto-Submitted: auto-generated Date: Fri, 07 Aug 2026 14:02:17 +0000 Message-Id: <6a75e569.43380.241c6341@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=545779a99290b7b7d94dece6c096ce230be91ff9 commit 545779a99290b7b7d94dece6c096ce230be91ff9 Author: Kevin Bowling AuthorDate: 2026-08-06 08:21:35 +0000 Commit: Kevin Bowling CommitDate: 2026-08-07 14:01:43 +0000 ixgbe: Re-enable the SFP laser during initialization ixgbe_if_stop() disables the transmit laser on every 82599 SFP fiber port, but the iflib initialization path did not re-enable it. Re-enable the laser before deferred SFP module setup so interface reinitialization cannot leave either single-speed or multispeed optics dark. The hardware wrapper is a no-op when laser control is unavailable. The placement follows Intel ix-3.4.39; this version deliberately applies to every SFP port affected by the stop path. MFC after: 1 week --- sys/dev/ixgbe/if_ix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 519c82304f54..96188ca7ef7f 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1836,6 +1836,8 @@ ixgbe_config_link(if_ctx_t ctx) sfp = ixgbe_is_sfp(hw); if (sfp) { + /* ixgbe_if_stop() disables it on every 82599 SFP port. */ + ixgbe_enable_tx_laser(hw); sc->task_requests |= IXGBE_REQUEST_TASK_MOD; iflib_admin_intr_deferred(ctx); } else {