From owner-freebsd-scsi@FreeBSD.ORG Wed Aug 14 02:47:06 2013 Return-Path: Delivered-To: FreeBSD-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id A4D2A77C for ; Wed, 14 Aug 2013 02:47:06 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm8-vm5.bullet.mail.ne1.yahoo.com (nm8-vm5.bullet.mail.ne1.yahoo.com [98.138.91.230]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6293F27E6 for ; Wed, 14 Aug 2013 02:47:05 +0000 (UTC) Received: from [98.138.101.129] by nm8.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2013 02:46:58 -0000 Received: from [98.138.226.131] by tm17.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2013 02:46:58 -0000 Received: from [127.0.0.1] by smtp218.mail.ne1.yahoo.com with NNFMP; 14 Aug 2013 02:46:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1376448418; bh=YBfxKs/NiCqx/OWPUUDmNtXXMT4UswnhDi7+4ISRSDk=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=zgbQBCKnqUXMNS9OvhDTbCsOp0sFsUdwYez9jZF10NLIyLnuJDNWqbUaeVlsu3x5unNklrmDucvwbDx2wsXUdp7y6bl3AzKq09FA6+3MQldoFzWsGcelRbAT0YkSRYjqFIN8pmaQqWb0vWc+JiBn+aQVFpDXf2kgeycWlAMNMAY= X-Yahoo-Newman-Id: 457099.72250.bm@smtp218.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 7nTCKPEVM1nlNBLUKKWhZkyrxYmi7SrueBFeMzYpPLesplv 6OeJrgXg0eshlaIyrtO7NbuBxEeOYQ6bEifuesuEAGuDA79eYkLhi7YvgYJr s.oO7yGt3gm4bZfQ.pDEFTW2BnbpFIfhwROd6FLs264ZkYZYWZ91OJtN7LbR lkD.gaKrn6aDs12RQ9solsPk6x3BcwEsgKcxHjBPggpbq90.M1ErKVMxjYo0 MTtYPrMECtLT8J2WWXLsg4KUm_uAvvjGG8hZ5r8b.uiEk72P9UwtDwlD4HeZ ijFyBgGwpyOfNTDKDZsqzJvahalgA1ehoWmF6KnVna5McUdYIePhYzjg2Vf3 WCNSyBOjiTfTbT07yM0jDjGojcHqK5WtYQ5eR8yvYeXmyI9U7oyz25_kd1WH TCnY7KAKVilZul5JdcOQLJPHynE9bEZGvRjgbTizxFOOAmqleoMm82oHF75C QZU2dY8uHQu026kXgj1.t_hbzK3qHq8WwBDR6BLKczdJv1HjPy3TP1KerwaU DJrop6WEEHg7qXS8yOhR7IpPlnTG.W5pChjvwI3NGbJplJ4KWKhUo0ULU X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [192.168.1.209] (sean_bruno@71.202.40.63 with ) by smtp218.mail.ne1.yahoo.com with SMTP; 13 Aug 2013 19:46:58 -0700 PDT Subject: Re: Dell H310, JBOD mode "hard error" From: Sean Bruno To: sbruno@freebsd.org In-Reply-To: <1373822621.1431.5.camel@localhost> References: <1373822621.1431.5.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-F13hOyrzBOZjHaUmC312" Date: Tue, 13 Aug 2013 19:46:56 -0700 Message-ID: <1376448416.1439.7.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: "FreeBSD-scsi@freebsd.org" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 02:47:06 -0000 --=-F13hOyrzBOZjHaUmC312 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sun, 2013-07-14 at 10:23 -0700, Sean Bruno wrote: > Not sure what to make of this. I've tested a lot of svn revisions of > the thunderbolt code, but nothing looks obvious. =20 >=20 > When I use a single drive in "SYSPD" mode on a Dell H310 (falcon or > skinny drake) I get a /dev/mfisyspd0 device. The JBOD mode *seems* to > work just fine as long as I don't do multiple things at once to it, e.g. > single user fsck works, but multiuser things die. >=20 > I get a failure case that emits errors such as: >=20 > g_vfs_done():error 27 in callback > mfisyspd0p2[READ(offset=3D7176192, length=3D425984)]mfisyspd0: hard error > error =3D 5 > cmd=3Dread 15360-16383 > error 27 in callback > g_vfs_done():mfisyspd0: hard error mfisyspd0p2[READ(offset=3D7602176, > length=3D524288)]cmd=3Dread error =3D 5 > 16384-17407 > error 27 in callback > g_vfs_done():mfisyspd0: hard error mfisyspd0p2[READ(offset=3D8126464, > length=3D524288)]cmd=3Dread error =3D 5 > 14560-15359 > error 27 in callback > g_vfs_done():mfisyspd0: hard error mfisyspd0p2[READ(offset=3D7192576, > length=3D409600)]cmd=3Dread error =3D 5 > 15360-16383 >=20 >=20 > Sean Ah, I see something that Yahoo! does that FreeBSD does not finally. We tune MAXPHYS *up* to (512 * 1024) because of performance and available memory. mfi(4) set's its own (MFI_MAXPHYS) to (128 * 1024) instead of using the value from sys/param.h (btw, I don't quite get why, but whatever). Without a min() check in mfi_syspd.c that mimics the one in mfi_disk.c, Yahoo code falls over in "SYSPD" mode (mfi(4) real jbod mode). Patch: Index: mfi_syspd.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- mfi_syspd.c (revision 254313) +++ mfi_syspd.c (working copy) @@ -128,7 +128,9 @@ sc->pd_disk->d_drv1 =3D sc; sc->pd_disk->d_maxsize =3D sc->pd_controller->mfi_max_io * secsize; sc->pd_disk->d_name =3D "mfisyspd"; - sc->pd_disk->d_open =3D mfi_syspd_open; + sc->pd_disk->d_maxsize =3D min(sc->pd_controller->mfi_max_io * secsize, + (sc->pd_controller->mfi_max_sge - 1) * PAGE_SIZE); + sc->pd_disk->d_close =3D mfi_syspd_close; sc->pd_disk->d_strategy =3D mfi_syspd_strategy; sc->pd_disk->d_dump =3D mfi_syspd_dump; --=-F13hOyrzBOZjHaUmC312 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSCu+YAAoJEBkJRdwI6BaHFRUH/RD/SQ97OjATNreOBaoRoYoT hmIEbtI1fxTP/vaFn2qOMupKSNdfR2MSD+znECkDcHYHtuLt6oL6Mey1WqP0KbLE QTndpxa8o8BZd8+6FuhcL7wnUQqtdH6MZM2arCanF0CVHBK4mj2jdCqY02HRkcoi UpL1VZklj8+ruk+BSpA2VaKKRuSnxMVsh1OZWDtOhSx6BSqWGnfDAxY5E/n9DnAJ vJ+gjLAVaZni0qgb85+rrBTxYfwMfoUrhCe5KU6Pw6gE3LPYpQ8E3n3YuEjdglst pHnaDQWLqqvm9b2jSsy0nEf0J8yfYjy2Laat31yuLEoAgJnl3vFVTYcPE0FwvOc= =TPi7 -----END PGP SIGNATURE----- --=-F13hOyrzBOZjHaUmC312--