From owner-freebsd-arch@freebsd.org Wed May 11 07:14:43 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C45BB36DEC for ; Wed, 11 May 2016 07:14:43 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2C08D11ED for ; Wed, 11 May 2016 07:14:43 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 2B629B36DEB; Wed, 11 May 2016 07:14:43 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B080B36DEA for ; Wed, 11 May 2016 07:14:43 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E7D1E11EC; Wed, 11 May 2016 07:14:42 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-io0-x230.google.com with SMTP id f89so43635283ioi.0; Wed, 11 May 2016 00:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=MmssOIe03nrNbsUOgQe4MelpjqjdIbNS/7/gILsudsw=; b=Ba2+jlsVCe4qV2vQj3Fh5jef6p/O4AkpewAaEJJwmAGs9GeiGDTr09sCJwAE6JJ85D Uazen8immMi4pN4AZtwwr5iO0Mp6EZhyLmJDnWNhhIXwYlfO7XVsHZKAGEYUD1ingMbl LDmi395PXoQwhtZavsoQM9k3P8y2Hq9F9OVyQqbOvccZ2HfwazXcqABOvyGbWx6EgIHn fXe2u4SXEFUCbOHfx9aU0CZBJVuaDceobKqNV7mRD6kvZLGxW6tBFBkcQ0Yt1B35XN19 MSZmd+2uWi8sM4HSlRIKrqe4GERR52fOq1tRrEkRQh9shKka6uma5pG9/cBDT3n8vnRJ YVkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=MmssOIe03nrNbsUOgQe4MelpjqjdIbNS/7/gILsudsw=; b=Y+Vs8YcI/LeWXUErw3/wrZRPAFw0JpZiRJIVeEi0fs2zzvxB37ty2jkb7ieaSKqJFC GyocdfHwHAGKzDMoAngzGd9nkoMjzt7xhm6gqOYJZkVkuCktCcSVmmEkmHSs1hDRxbXc sZ/n0KYOZMRgsqExTq/k8hN4RZFF9JsY5/fbTdL27JUMUyqAPupoztkkbTjT0RZQMHs3 wIMFJLanO7Q5Lj/C6MLNzjqoeU1/earFtA9J7VocZc0Ezuxo2ygFtND/Ql046onjFs2i YFb6OT5PJKUmv+pPuO883xxWyVJDokV8n8Ho5U77lN85YV+jh5o76eYU2Owh2S4EqHKr SfQA== X-Gm-Message-State: AOPr4FXotNnD9cF43uUqNw9nNpSd7E6r28Hof7dANdOcQm241QSEDSsS1SFjmRnCRrnFN1hEqW8Bkf8hoGFr6Q== MIME-Version: 1.0 X-Received: by 10.107.7.170 with SMTP id g42mr1942264ioi.81.1462950882415; Wed, 11 May 2016 00:14:42 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.107.140.8 with HTTP; Wed, 11 May 2016 00:14:42 -0700 (PDT) In-Reply-To: References: Date: Wed, 11 May 2016 00:14:42 -0700 X-Google-Sender-Auth: nfxCSnwJckWrtA34bxXu9PTwvIM Message-ID: Subject: Re: KASSERT: always assert; KWARN From: "K. Macy" To: Adrian Chadd Cc: "cem@freebsd.org" , "freebsd-arch@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 07:14:43 -0000 Ugh. Et tu Brutus. Then they either shouldn't be asserts or you need a new mode for Adrian and friends. Either way, if people don't want to hit panics from asserts they should not run with invariants enabled. No one other than manic depressive developers look at logs in the common case. On Tuesday, May 10, 2016, Adrian Chadd wrote: > i found it very useful to get asserts to print, rather than panic. > > > > -a > > > On 10 May 2016 at 18:24, Conrad Meyer > > wrote: > > I'd like to logically revert r243980 and r244105, such that KASSERT > > uses the __dead2-annotated panic(9). > > > > Going back to the old behavior enables Coverity and other static > > analyzers to reason about KASSERT invariants via the __dead2 panic(9) > > path. > > > > This proposal is in https://reviews.freebsd.org/D6117 . > > > > As a follow-up, to match the assumed intent of the r243980 changes, I > > propose a KWARN facility which may be muted, rate limited, or even > > cause panic. Generally, KASSERTs should not be KWARNs. That proposal > > is here: https://reviews.freebsd.org/D6134 > > > > Finally, I am looking for suggestions of things it *does* make sense > > to KWARN about. One suggestion was witness_warn; however, it doesn't > > seem like a great fit (without adding allocating sbufs in, anyway). A > > sketch of that is in https://reviews.freebsd.org/D6306 . > > > > Thoughts or objections? Does anyone like the ability to opt out of > > invariants asserts? > > > > Best, > > Conrad > > _______________________________________________ > > freebsd-arch@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org > " > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org > " >