From owner-freebsd-arm@FreeBSD.ORG Sun Feb 15 14:48:57 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B81EEF33 for ; Sun, 15 Feb 2015 14:48:57 +0000 (UTC) Received: from mail-ob0-x22c.google.com (mail-ob0-x22c.google.com [IPv6:2607:f8b0:4003:c01::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77A69F1B for ; Sun, 15 Feb 2015 14:48:57 +0000 (UTC) Received: by mail-ob0-f172.google.com with SMTP id nt9so34752754obb.3 for ; Sun, 15 Feb 2015 06:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sOcmABzEuwURLNCMwAT4YQFkeFiaVcDbBnVy9hrWBG0=; b=l+vSSXFGL23JJqtGxmJOF6Rjwi+lKnux8GVBN2AteNRW70dqSW5BrbrPIjfX/0yh1p KhS0NxJXYNNZqBgNq8uDW7ZyLC6gwstiwUJ5csaVVogBvPLBLvkXW2vifxiBxuv2o2wP Et2TsJ+ogsJkc6oGq+vcstQ28wbv40yMebKn3R39bbeUg6PY59pcLLy5kUDQpuqtW4hV xb3bf2DOrmowiVbUasaNx+pU8Ie7DFPuY45wfr4kYc0/I5xn6hCrXrMrFvzUGr7dZjO6 Ave8IjhRUFh0jfpWJr6cjEhuj21rTWOnQynpJugAQ8acP+Db3Ktp8EfwZs8bzEW9v7vd 4cQg== MIME-Version: 1.0 X-Received: by 10.60.156.168 with SMTP id wf8mr2227071oeb.5.1424011736802; Sun, 15 Feb 2015 06:48:56 -0800 (PST) Received: by 10.182.13.33 with HTTP; Sun, 15 Feb 2015 06:48:56 -0800 (PST) In-Reply-To: <201502110535.t1B5Z3c7007720@jwlab.FEITH.COM> References: <201502110535.t1B5Z3c7007720@jwlab.FEITH.COM> Date: Sun, 15 Feb 2015 22:48:56 +0800 Message-ID: Subject: Re: Initial Amlogic aml8726-m6 and aml8726-m8 support files From: Ganbold Tsagaankhuu To: John Wehle Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-arm@freebsd.org" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 14:48:57 -0000 On Wed, Feb 11, 2015 at 1:35 PM, John Wehle wrote: > Ganbold Tsagaankhuu wrote on Mon Feb 2 07:19:11 UTC 2015: > > > Maybe making mmc stable is more priority. > > Try the attached patch. > > -- John > --------------------8<-------------------8<----------------------------- > --- sys/arm/amlogic/aml8726/aml8726_mmc.c.ORIGINAL 2015-01-07 > 00:57:31.000000000 -0500 > +++ sys/arm/amlogic/aml8726/aml8726_mmc.c 2015-02-10 > 23:51:49.000000000 -0500 > @@ -353,7 +353,8 @@ aml8726_mmc_intr(void *arg) > return; > } > > - if ((isr & AML_MMC_IRQ_STATUS_CMD_BUSY) != 0) { > + if ((isr & AML_MMC_IRQ_STATUS_CMD_BUSY) != 0 > + && (isr & AML_MMC_IRQ_STATUS_CMD_DONE_IRQ) == 0) { > if (mmc_error != MMC_ERR_TIMEOUT) > mmc_error = MMC_ERR_FAILED; > > @@ -431,13 +432,14 @@ aml8726_mmc_intr(void *arg) > } > > /* > - * If this command was successfully executed and there's > - * a linked stop command, then start the stop command. > + * If there's a linked stop command, then start the stop command. > + * In order to establish a known state attempt the stop command > + * even if the original request encountered an error. > */ > > stop_cmd = (cmd->mrq->stop != cmd) ? cmd->mrq->stop : NULL; > > - if (stop_cmd != NULL && mmc_error == MMC_ERR_NONE) { > + if (stop_cmd != NULL) { > mmc_stop_error = aml8726_mmc_start_command(sc, stop_cmd); > if (mmc_stop_error == MMC_ERR_NONE) { > AML_MMC_UNLOCK(sc); > ------------------------------------------------------------------------- > | Feith Systems | Voice: 1-215-646-8000 | Email: john@feith.com | > | John Wehle | Fax: 1-215-540-5495 | | > ------------------------------------------------------------------------- > > It seems better, but still panics. http://pastebin.ca/2928101 Ganbold