From owner-svn-src-all@FreeBSD.ORG Tue Apr 12 13:04:27 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35842106566C; Tue, 12 Apr 2011 13:04:27 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from adsum.doit.wisc.edu (adsum.doit.wisc.edu [144.92.197.210]) by mx1.freebsd.org (Postfix) with ESMTP id 029B38FC15; Tue, 12 Apr 2011 13:04:26 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0LJJ0030AIZEVP00@smtpauth1.wiscmail.wisc.edu>; Tue, 12 Apr 2011 08:04:26 -0500 (CDT) Received: from comporellon.tachypleus.net ([unknown] [76.210.65.155]) by smtpauth1.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0LJJ000MDIZ8JQ00@smtpauth1.wiscmail.wisc.edu>; Tue, 12 Apr 2011 08:04:24 -0500 (CDT) Date: Tue, 12 Apr 2011 08:04:20 -0500 From: Nathan Whitehorn In-reply-to: <201104121457.26348.hselasky@freebsd.org> To: Hans Petter Selasky Message-id: <4DA44DD4.2090105@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.65.155 X-Spam-PmxInfo: Server=avs-14, Version=5.6.0.2009776, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.4.12.125416, SenderIP=76.210.65.155 References: <201104120749.p3C7nBDQ014198@svn.freebsd.org> <4DA447F7.50104@freebsd.org> <201104121457.26348.hselasky@freebsd.org> User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110305 Thunderbird/3.1.9 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r220558 - in head/sys: arm/econa dev/usb/controller mips/atheros mips/rmi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2011 13:04:27 -0000 On 04/12/11 07:57, Hans Petter Selasky wrote: > On Tuesday 12 April 2011 14:39:19 Nathan Whitehorn wrote: >> On 04/12/11 02:49, Hans Petter Selasky wrote: >>> Author: hselasky >>> Date: Tue Apr 12 07:49:11 2011 >>> New Revision: 220558 >>> URL: http://svn.freebsd.org/changeset/base/220558 >>> >>> Log: >>> We don't need to call EOWRITE4(sc, EHCI_USBINTR, 0) directly from each >>> EHCI bus driver at detach, hence ehci_detach() does exactly this >>> since r199718. >> Just so you're aware, there's also another EHCI driver in the tree at >> /sys/powerpc/ps3/ehci_ps3.c. It might also need some modifications at >> various points when you're cleaning up EHCI drivers. > This driver doesn't have a detach method. The patches don't apply to this > driver then. Should I add a detach method or is it superfluous? No, neither it nor the bus to which it is attached support detaching devices (I was lazy when I wrote), so it's moot for this change. This was just a heads-up for future cleanups. -Nathan