Date: Wed, 28 Jan 2015 13:51:25 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, svn-src-projects@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>, Dimitry Andric <dim@FreeBSD.org>, Alexander Kabaev <kabaev@gmail.com> Subject: Re: svn commit: r277803 - projects/clang360-import/lib/clang/include Message-ID: <54C93DBD.6020609@FreeBSD.org> In-Reply-To: <20150128091457.1b0ea3a7@kan> References: <201501271925.t0RJPem3010417@svn.freebsd.org> <CAJ5_RoAvww7xFsSTBMPDThYsbpVbxOs11nWE=eEXpJRFx_kyww@mail.gmail.com> <20150127191134.4fe3a17f@kan> <F7477A20-BC56-4CF9-8520-77F7BFD4B72E@FreeBSD.org> <20150128091457.1b0ea3a7@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fe9R1IesFKse5vRnb0Uj6wEKKC0NCF3xH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/28/2015 8:14 AM, Alexander Kabaev wrote: > On Wed, 28 Jan 2015 08:42:48 +0100 > Dimitry Andric <dim@FreeBSD.org> wrote: >=20 >> On 28 Jan 2015, at 01:11, Alexander Kabaev <kabaev@gmail.com> wrote: >> On Tue, 27 Jan 2015 14:34:21 -0500 >>> >>> Benjamin Kaduk <bjkfbsd@gmail.com> wrote: >>> >>>> On Tue, Jan 27, 2015 at 2:25 PM, Dimitry Andric <dim@freebsd.org> >>>> wrote: >>>> >>>>> Author: dim >>>>> Date: Tue Jan 27 19:25:39 2015 >>>>> New Revision: 277803 >>>>> URL: https://svnweb.freebsd.org/changeset/base/277803 >>>>> >>>>> Log: >>>>> Change the path to clang's private headers. Upstream has always >>>>> stored these in $LIBDIR/clang/$VERSION/include, instead of our >>>>> previous custom location in /usr/include/clang/$VERSION. This >>>>> allows us to drop yet another FreeBSD-specific patch. >>>>> >>>>> Modified: >>>>> projects/clang360-import/lib/clang/include/Makefile >>>>> >>>>> Modified: projects/clang360-import/lib/clang/include/Makefile >>>>> >>> >>> I think spreading .h files all over the tree is actually a >>> regression. >> >> I'm not sure what the problem is with storing a compiler's >> internal-only headers in the location where upstream expects them to >> be? Note that gcc does something similar; for example with the gcc49 >> port, it stores all its internal headers under: >> >> /usr/local/lib/gcc49/gcc/i386-portbld-freebsd11.0/4.9.3/include >> >> While I do agree that this is not a pretty-looking path, upstream has >> chosen it to be like this, and there are most likely good reasons for >> it. As for clang, I just want to get rid of as many "FreeBSD is a >> special snowflake" patches as I can. >> >> -Dimitry >> >=20 > Nobody _expects_ them to be there, for they are internal and not > directly addressable by anyone. We can tweak locations as we see fit > with no user visible consequences. What you destroy by this is the nice= > property we had to date - all of the base headers could be searched by > simple grep on /usr/include and no obscure directories need to be > remembered. Also note that ports can do whatever they want as long they= > do not stomp on the word, my concern is about base only. >=20 I've often grepped internal headers in /usr/include to try to understand some compiler errors better. This was mostly with C++ template errors. I did not know GCC was storing headers in /usr/lib/.../include. Having to include /usr/lib/.../include is a little annoying, but it is even more annoying to have FreeBSD be different than other platforms, assuming those other systems are adopting the upstream location as well. --=20 Regards, Bryan Drewery --fe9R1IesFKse5vRnb0Uj6wEKKC0NCF3xH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUyT29AAoJEDXXcbtuRpfPTecH/RbT/oPVCgNDVB9yUGCfTfX/ cs85pFvCq+AFrMHq46I8ATEx7yySR8jBsCnq55XesKttXNN+qQoZD7Bk7qayA2AG C0ta9QRxXP/9lzJNHAoIPyGC4TAsVicg2SdpJv0vmSoKsYgV6Dgck8NqEkTMepzJ Gn87CD1SXBNaUNPyjpYAwlPmTUmi4JGzTgjQrCFDk/hyEAaELk5UqUVqpxgImyZy wAG+mtoPU2Of0OXuUbrLHoe9McZ3AqiX/x5wCI9G1qh7olrFIMVD7dLMQw+3aEZf LAoyYgbpdiX4mebJIDLdU8fXo2R6u2r7aXi/bbsKa+fRjxIcqfj6Fzzn0dN4S3w= =asA4 -----END PGP SIGNATURE----- --fe9R1IesFKse5vRnb0Uj6wEKKC0NCF3xH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54C93DBD.6020609>