From owner-svn-src-head@freebsd.org Tue Feb 2 19:44:27 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 000B9A995FF; Tue, 2 Feb 2016 19:44:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5376180; Tue, 2 Feb 2016 19:44:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 99842B918; Tue, 2 Feb 2016 14:44:25 -0500 (EST) From: John Baldwin To: Alfred Perlstein Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295136 - in head: sys/kern sys/netinet sys/sys usr.bin/netstat Date: Tue, 02 Feb 2016 11:39:46 -0800 Message-ID: <36439709.poT7RgRunK@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201602020557.u125vxCP084718@repo.freebsd.org> References: <201602020557.u125vxCP084718@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 02 Feb 2016 14:44:25 -0500 (EST) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 19:44:27 -0000 On Tuesday, February 02, 2016 05:57:59 AM Alfred Perlstein wrote: > Author: alfred > Date: Tue Feb 2 05:57:59 2016 > New Revision: 295136 > URL: https://svnweb.freebsd.org/changeset/base/295136 > > Log: > Increase max allowed backlog for listen sockets > from short to int. > > PR: 203922 > Submitted by: White Knight > MFC After: 4 weeks You do realize that this breaks the ABI of the sysctls used to fetch connection lists (and so will break existing binaries like ucd-snmpd, etc.) and thus can't be MFC'd right? Also, when this patch was brought up on the lists there was the question of if it is really beneficial to have more than 32k sockets that you haven't accepted yet. It's one thing to have lots of concurrent active sockets that you are servicing, but if your application is so backlogged that there are 32k sockets waiting on accept() it's hard to imagine why having more than 32k sockets waiting on accept() is useful. -- John Baldwin