From owner-svn-src-head@freebsd.org Mon Jan 13 18:45:28 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F110A1E81D0 for ; Mon, 13 Jan 2020 18:45:28 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47xMwS5bm2z42JW for ; Mon, 13 Jan 2020 18:45:28 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1578941127; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=hbzPHHZVcMFrctZP+kH3gxzmQchTSRePsq239mKJHBYv3u+976VXq2RQtD+jLmOUrhy9rJshkEP79 FTHqm/Ni69KafNrt98hOPh4vtGLF+RBd1i2xkJAPjSEhSEoM9topIw3CLae4FS6hh8a7CbQJCi1LAg PSNAsB3N1R+NTj4tHUT6jkhCLT4qMqjbkBaKjSY8B8Jr7wJaWyH3e7WHLCFFLygwFqVbozEBW4NKv6 MM73zY6aqizfUqa5rWJIiwPdNWXIA7J5TW/tSTxDCXZ+t7fK3NvFjpwWAcM2NqqUjJjwUKmpY1bVU7 ZQ7W3RnVXWLyb9Ve7IPV6VHBqk0jePQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=X/fB/+w5Krp/0QvHEpFd9ovkLTcPohzEoGgmWF74YIs=; b=Wgh0XbV3kztGd7FJ5O8csvO7EnLjMa8dy/boEv/RFBt8y3Zhv2VNppBdD+e1GMr1e3PyntAw9P3eD aBbo2Op45+tY0GZKCIpr5SBcbjiEN267FUh5OMYU4DpKDbXwFGCc4OyfYECe468TyNVxMbZAcmPXp9 zm9eykQ4VsfgXL9+PZGWbUMgAzinrEphKP5KqILx38jNS9vmGDSosgTurTW82ZhLWZaYuQLiQP0p5p s1eF5Vj4q3pwOUfmzSvam6XTWAmc7tZsIqlCBsas7xMLntxrYQ9l5nNhYDJ+v9Rg5+MONtiBg/+DQF IT8/RQqPhmbHz42RUae0EJ2qgHZsw5Q== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=X/fB/+w5Krp/0QvHEpFd9ovkLTcPohzEoGgmWF74YIs=; b=ve4stQ/U+DPo2AKoO4RjmpigTTWlaHRwABahcAoXBWgnySt03A3/rEBB6vcSOev1D2nG913CcODwU BvY/YB0uuXAxFGDjGdwqOQ2c2v0Lcmycpd8DNcJac/1w8L3ReBWylLFSzVDpar4lkjEnbLnJWwx1Oo n9u8aVsLLh17/jIXqEEsRKmaFMOXyOA5nfE/A0pvnCqrpVlvTkvBrVUen+Hts8mOvVGUk1F+uE/6NQ DUusPfCCNjntJk8Zf/GznxWFtcZ+g1By83OwP+ICJgJbCoqnTJoZyBdAXq0+f0Ht5pk2VTrWXUpLax c4u1J4P0OXlnD/aiYPo/iyLiG6dPqSg== X-MHO-RoutePath: aGlwcGll X-MHO-User: dc78efbf-3634-11ea-b80d-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id dc78efbf-3634-11ea-b80d-052b4a66b6b2; Mon, 13 Jan 2020 18:45:26 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 00DIjPQe055439; Mon, 13 Jan 2020 11:45:25 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <15236c9adbb7ec8c90375e283f7d1d5d5eafe6be.camel@freebsd.org> Subject: Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib From: Ian Lepore To: Toomas Soome Cc: Toomas Soome , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 13 Jan 2020 11:45:25 -0700 In-Reply-To: <4437F251-43CC-4DED-B449-00A9516C75E2@me.com> References: <202001131822.00DIMtrW016338@repo.freebsd.org> <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org> <4437F251-43CC-4DED-B449-00A9516C75E2@me.com> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47xMwS5bm2z42JW X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; NEURAL_HAM_LONG(-0.99)[-0.991,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 18:45:29 -0000 On Mon, 2020-01-13 at 20:43 +0200, Toomas Soome wrote: > > On 13. Jan 2020, at 20:31, Ian Lepore wrote: > > > > On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: > > > Author: tsoome > > > Date: Mon Jan 13 18:22:54 2020 > > > New Revision: 356693 > > > URL: https://svnweb.freebsd.org/changeset/base/356693 > > > > > > Log: > > > loader: allocate properly aligned buffer for network packet > > > > > > Use memalign(4, size) to ensure we have properly aligned buffer. > > > > > > MFC after: 2 weeks > > > > > > Modified: > > > head/stand/efi/libefi/efinet.c > > > head/stand/i386/libi386/pxe.c > > > head/stand/libofw/ofw_net.c > > > head/stand/uboot/lib/net.c > > > > > > > The malloc implementation in libstand already g'tees minimum > > alignment > > of 16 bytes on most arches, 64 bytes on arches that use u-boot (see > > libsa/zalloc_defs.h). So how does this change anything? > > > > Hi! > > Well, given the amount of knobs etc, it does not hurt to be explicit, > does it? > > rgds, > toomas I think it does hurt, because now it misleads you into thinking it's 4- byte aligned when it's actually 16 or 64. (That's what made me reply at all, my first gut reaction to reading the commit message was "but 4 is not at all the right alignment on many platforms"). -- Ian