From owner-freebsd-geom@FreeBSD.ORG  Wed Aug 18 19:40:03 2010
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 83FAC10656A6
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Aug 2010 19:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6FF0D8FC08
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Aug 2010 19:40:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IJe3gq063619
	for <freebsd-geom@freefall.freebsd.org>; Wed, 18 Aug 2010 19:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IJe3wf063617;
	Wed, 18 Aug 2010 19:40:03 GMT (envelope-from gnats)
Date: Wed, 18 Aug 2010 19:40:03 GMT
Message-Id: <201008181940.o7IJe3wf063617@freefall.freebsd.org>
To: freebsd-geom@FreeBSD.org
From: Kostik Belousov <kostikbel@gmail.com>
Cc: 
Subject: Re: kern/149762: volume labels with rogue characters
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kostik Belousov <kostikbel@gmail.com>
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 19:40:03 -0000

The following reply was made to PR kern/149762; it has been noted by GNATS.

From: Kostik Belousov <kostikbel@gmail.com>
To: Oliver Fromme <olli@lurza.secnetix.de>
Cc: freebsd-geom@freebsd.org, bug-followup@freebsd.org, walter@pelissero.de
Subject: Re: kern/149762: volume labels with rogue characters
Date: Wed, 18 Aug 2010 21:58:31 +0300

 --b6tME5Uow9dgAUD7
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote:
 > Oliver Fromme wrote:
 >  >  I have reviewed the patch (the second one from the followup),
 >  >  and it looks good to me, except for a few minor style(9)
 >  >  issues, and one type problem:  By default, char is unsigned,
 >                                               ^^^^^^^^^^^^^^^^^^
 >  >  so the comparisons p <=3D ' ' and p > '~' probably don't do
 >  >  what you expect.
 >=20
 > I'm sorry, I meant signed, of course.
 > You need to specify "unsigned char" if you want it to be unsigned.
 
 Signedness of char is implementation-depended. It is signed on x86-oids,
 and unsigned on powerpc, AFAIR.
 
 --b6tME5Uow9dgAUD7
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO
 798An0wmSPW4dbr4fReYCvPaN/9AbLdl
 =sCVM
 -----END PGP SIGNATURE-----
 
 --b6tME5Uow9dgAUD7--