Date: Wed, 19 Aug 1998 00:20:52 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, dfr@nlsystems.com Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/include cpufunc.h Message-ID: <199808181420.AAA09667@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> > Modified files:
>> > sys/i386/include cpufunc.h
>> > Log:
>> > Add macros for accessing device memory.
>>
>> This is completely misplaced. i386/include/cpufunc.h is for
>> "providing access to special i386 functions". Device memory
oops, instructions (quote from cpufunc.h)
>> access functions are already in <machine/bus.h>.
>
>The memory access macros should go in the same place as the port access
>ones. If they should move to <machine/bus.h> then so should inx/outx.
No they shouldn't, unless they are (confused with) "special i386
instructions". inb() and outb() etc. are not port access macros; they
are functions to "access special i386 instructions". <machine/bus.h>
already provides higher level i/o access functions, partly built out of
these primitives and partly with direct asms. Many drivers still access
inb() and outb() directly but probably shouldn't.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808181420.AAA09667>