Date: Fri, 3 May 2024 17:56:41 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: =?UTF-8?Q?T=C4=B3l_Coosemans?= <tijl@freebsd.org> Cc: "Tobias C. Berner" <tcberner@gmail.com>, Gleb Popov <arrowd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <CAMHz58SBWcS%2BLYO%2BTDmiud2YdVUB8drWV0KRDtkBB8aSM0HroA@mail.gmail.com> In-Reply-To: <20240419130529.6068bc4b@hal.tijl.coosemans.org> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> <2567403.0dHE6SNnxz@angua.firefly> <CAMHz58Qa2pyN6qs-mFr9aHgtQoGrd1hbhF=ahx5ahR-0CB-7uQ@mail.gmail.com> <20240324202715.5d18838d@hal.tijl.coosemans.org> <CAMHz58QZ0bQh51s4j9CNt7yRZX8=uQi-cDp3ok6FN8ie0v=Gbw@mail.gmail.com> <20240331234553.1793b816@hal.tijl.coosemans.org> <CAMHz58RqvKTL=5C8ZX0YsENfsgoSYhV3pdFANFX5myeVuZT-cw@mail.gmail.com> <20240419130529.6068bc4b@hal.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000c8d018061789bed0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Fri, Apr 19, 2024 at 7:05=E2=80=AFPM T=C4=B3l Coosemans <tijl@freebsd.or=
g> wrote:
> On Tue, 9 Apr 2024 05:08:10 +0800 Po-Chuan Hsieh wrote:
> > On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebsd=
.org> wrote:
> >> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
> >>> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <tijl@free=
bsd.org>
> wrote:
> >>>> - Some fonts have been split into x11-fonts/<font>-basic providing
> Bold,
> >>>> BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra
> providing
> >>>> additional styles. Only some of these have x11-fonts/<font> as a
> >>>> metaport currently. This needs to be made consistent. I think it
> >>>> would be best to drop the metaports and move x11-fonts/<font>-basi=
c
> to
> >>>> x11-fonts/<font>. That way pkg install <font> installs the common
> >>>> styles for all fonts. I think that this would be the most
> >>>> intuitive/convenient.
> >>>> (I was hoping to use subpackages for this instead of extra ports.)
> >>>
> >>> The -basic/-extra structure was kept for minimal change.
> >>> I agree with you that it would be better to be consistent with all
> other
> >>> noto ports.
> >>> I could merge the following ports:
> >>> - noto-sans-basic/-extra
> >>> - noto-sans-mono-basic/-extra
> >>> - noto-sans-symbols-basic/-extra
> >>> - noto-serif-basic/-extra
> >>> However, what should be noto-basic's dependencies after the merge?
> >>
> >> It's okay to keep the -extra ports. What I meant was to rename the
> >> -basic ports so noto-sans-basic becomes noto-sans for example.
> >
> > I've prepared a patch [1] for the following changes:
> > - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
> > - Merge x11-fonts/noto-sans-mono-{basic,extra} to
> x11-fonts/noto-sans-mono
> > - Merge x11-fonts/noto-sans-symbols-{basic,extra} to
> > x11-fonts/noto-sans-symbols
> > - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
> > - Update x11-fonts/noto-basic to depend on the 4 merged ports
> > - Update x11-fonts/noto-extra by removing the 4 -extra ports from
> > RUN_DEPENDS
> >
> > [1] https://people.freebsd.org/~sunpoet/patch/noto.txt
>
> Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missin=
g.
>
I've put x11-fonts/noto-sans and x11-fonts/noto-serif patch in
https://people.freebsd.org/~sunpoet/patch/noto-part2.txt
Not sure why it is missing in the previous patch.
--000000000000c8d018061789bed0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Apr 19, 2024 at 7:05=E2=80=AFPM T=
=C4=B3l Coosemans <<a href=3D"mailto:tijl@freebsd.org" target=3D"_blank"=
>tijl@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">On Tue, 9 Apr 2024 05:08:10 +08=
00 Po-Chuan Hsieh wrote:<br>
> On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans <<a href=
=3D"mailto:tijl@freebsd.org" target=3D"_blank">tijl@freebsd.org</a>> wro=
te:<br>
>> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:<br>
>>> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <=
;<a href=3D"mailto:tijl@freebsd.org" target=3D"_blank">tijl@freebsd.org</a>=
> wrote:<br>
>>>> - Some fonts have been split into x11-fonts/<font>-b=
asic providing Bold,<br>
>>>>=C2=A0 =C2=A0BoldItalic, Italic, and Regular, and x11-fonts=
/<font>-extra providing<br>
>>>>=C2=A0 =C2=A0additional styles.=C2=A0 Only some of these ha=
ve x11-fonts/<font> as a<br>
>>>>=C2=A0 =C2=A0metaport currently.=C2=A0 This needs to be mad=
e consistent.=C2=A0 I think it<br>
>>>>=C2=A0 =C2=A0would be best to drop the metaports and move x=
11-fonts/<font>-basic to<br>
>>>>=C2=A0 =C2=A0x11-fonts/<font>.=C2=A0 That way pkg ins=
tall <font> installs the common<br>
>>>>=C2=A0 =C2=A0styles for all fonts.=C2=A0 I think that this =
would be the most<br>
>>>>=C2=A0 =C2=A0intuitive/convenient.<br>
>>>>=C2=A0 =C2=A0(I was hoping to use subpackages for this inst=
ead of extra ports.)<br>
>>><br>
>>> The -basic/-extra structure was kept for minimal change.<br>
>>> I agree with you that it would be better to be consistent with=
all other<br>
>>> noto ports.<br>
>>> I could merge the following ports:<br>
>>> - noto-sans-basic/-extra<br>
>>> - noto-sans-mono-basic/-extra<br>
>>> - noto-sans-symbols-basic/-extra<br>
>>> - noto-serif-basic/-extra<br>
>>> However, what should be noto-basic's dependencies after th=
e merge?<br>
>><br>
>> It's okay to keep the -extra ports.=C2=A0 What I meant was to =
rename the<br>
>> -basic ports so noto-sans-basic becomes noto-sans for example.<br>
> <br>
> I've prepared a patch [1] for the following changes:<br>
> - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans<br>
> - Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-=
mono<br>
> - Merge x11-fonts/noto-sans-symbols-{basic,extra} to<br>
> x11-fonts/noto-sans-symbols<br>
> - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif<br>
> - Update x11-fonts/noto-basic to depend on the 4 merged ports<br>
> - Update x11-fonts/noto-extra by removing the 4 -extra ports from<br>
> RUN_DEPENDS<br>
> <br>
> [1]=C2=A0 <a href=3D"https://people.freebsd.org/~sunpoet/patch/noto.tx=
t" rel=3D"noreferrer" target=3D"_blank">https://people.freebsd.org/~sunpoet=
/patch/noto.txt</a><br>
<br>
Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missing.=
<br></blockquote><div><br></div><div>I've put=C2=A0x11-fonts/noto-sans =
and x11-fonts/noto-serif patch in <a href=3D"https://people.freebsd.org/~su=
npoet/patch/noto-part2.txt" target=3D"_blank">https://people.freebsd.org/~s=
unpoet/patch/noto-part2.txt</a></div><div>Not sure why it is missing in the=
previous patch.</div></div></div>
--000000000000c8d018061789bed0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SBWcS%2BLYO%2BTDmiud2YdVUB8drWV0KRDtkBB8aSM0HroA>