From owner-p4-projects@FreeBSD.ORG  Mon Oct  8 06:57:15 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E38CE16A476; Mon,  8 Oct 2007 06:57:14 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D3E016A418
	for <perforce@freebsd.org>; Mon,  8 Oct 2007 06:57:14 +0000 (UTC)
	(envelope-from kevlo@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D2A213C4B7
	for <perforce@freebsd.org>; Mon,  8 Oct 2007 06:57:13 +0000 (UTC)
	(envelope-from kevlo@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l986vDNX074741
	for <perforce@freebsd.org>; Mon, 8 Oct 2007 06:57:13 GMT
	(envelope-from kevlo@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l986vDpO074738
	for perforce@freebsd.org; Mon, 8 Oct 2007 06:57:13 GMT
	(envelope-from kevlo@freebsd.org)
Date: Mon, 8 Oct 2007 06:57:13 GMT
Message-Id: <200710080657.l986vDpO074738@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	kevlo@freebsd.org using -f
From: Kevin Lo <kevlo@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 127298 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2007 06:57:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=127298

Change 127298 by kevlo@kevlo_rtsl on 2007/10/08 06:56:52

	Change bwi_stop() returns void rather than int for consistency.

Affected files ...

.. //depot/projects/wifi/sys/dev/bwi/if_bwi.c#3 edit

Differences ...

==== //depot/projects/wifi/sys/dev/bwi/if_bwi.c#3 (text+ko) ====

@@ -114,7 +114,7 @@
 static void bwi_rx_radiotap(struct bwi_softc *, struct mbuf *,
 			struct bwi_rxbuf_hdr *, const void *, int);
 
-static int	bwi_stop(struct bwi_softc *);
+static void	bwi_stop(struct bwi_softc *);
 static int	bwi_newbuf(struct bwi_softc *, int, int);
 static int	bwi_encap(struct bwi_softc *, int, struct mbuf *,
 			  struct ieee80211_node *);
@@ -1064,12 +1064,7 @@
 
 	DPRINTF(sc, "%s\n", __func__);
 
-	error = bwi_stop(sc);
-	if (error) {
-		if_printf(ifp, "can't stop\n");
-		BWI_UNLOCK(sc);
-		return;
-	}
+	bwi_stop(sc);
 
 	bwi_bbp_power_on(sc, BWI_CLOCK_MODE_FAST);
 
@@ -1319,7 +1314,7 @@
 	BWI_UNLOCK(sc);
 }
 
-static int
+static void
 bwi_stop(struct bwi_softc *sc)
 {
 	struct ieee80211com *ic = &sc->sc_ic;
@@ -1367,8 +1362,6 @@
 	ifp->if_timer = 0;
 	ifp->if_drv_flags &= ~(IFF_DRV_RUNNING | IFF_DRV_OACTIVE);
 	BWI_UNLOCK(sc);
-
-	return 0;
 }
 
 void