From owner-freebsd-stable@FreeBSD.ORG Sun Jan 8 05:24:33 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB67616A41F; Sun, 8 Jan 2006 05:24:33 +0000 (GMT) (envelope-from gjp@in-addr.com) Received: from noop.colo.erols.net (noop.colo.erols.net [207.96.1.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7294043D45; Sun, 8 Jan 2006 05:24:33 +0000 (GMT) (envelope-from gjp@in-addr.com) Received: from uucp by noop.colo.erols.net with local-rmail (Exim 4.52 (FreeBSD)) id 1EvT2e-000DCn-JC; Sun, 08 Jan 2006 00:24:32 -0500 Received: from localhost.home.in-addr.com ([127.0.0.1]:57273) by rimmer.home.in-addr.com with esmtp (Exim 4.60 (FreeBSD)) (envelope-from ) id 1EvT2U-000DSI-E0; Sun, 08 Jan 2006 05:24:22 +0000 Message-ID: <43C0A206.6020103@in-addr.com> Date: Sun, 08 Jan 2006 05:24:22 +0000 From: Gary Palmer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051130 X-Accept-Language: en-gb, en, en-us MIME-Version: 1.0 To: "M. Warner Losh" References: <43C05270.60106@freebsd.org> <43C07B16.7050505@errno.com> <43C09F08.1080707@freebsd.org> <20060107.221615.106545203.imp@bsdimp.com> In-Reply-To: <20060107.221615.106545203.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-stable@freebsd.org Subject: Re: devd and caseful device ID matching on 6.0 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2006 05:24:33 -0000 M. Warner Losh wrote: >This works. However, matches should already be case insensitive. If >they aren't, then I need to investigate why not. > > My reading of regex(3) says that the reg_comp at line 173 of devd.cc needs to add the REG_ICASE flag. i.e. regcomp(&_regex, _re.c_str(), REG_EXTENDED | REG_NOSUB | REG_ICASE); Testing seeems to show that adding that flag makes "match" case-insensitive. Regards, Gary