From owner-freebsd-hackers Thu Jul 13 18:36: 3 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 1E3E037B9BF for ; Thu, 13 Jul 2000 18:35:59 -0700 (PDT) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id e6E1Zvg11710; Thu, 13 Jul 2000 18:35:57 -0700 (PDT) Date: Thu, 13 Jul 2000 18:35:57 -0700 From: Alfred Perlstein To: Wilbert de Graaf Cc: FreeBSD-hackers Subject: Re: #include question: requires Message-ID: <20000713183557.A25571@fw.wintelcom.net> References: <095401bfec6f$495ba110$0a00a8c0@alias> <20000712221526.L25571@fw.wintelcom.net> <396E49D4.DBBA9B5C@hetnet.nl> <20000713160251.Z25571@fw.wintelcom.net> <396E5A9E.E7CD05F1@hetnet.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <396E5A9E.E7CD05F1@hetnet.nl>; from wilbertdg@hetnet.nl on Thu, Jul 13, 2000 at 05:11:10PM -0700 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Wilbert de Graaf [000713 17:11] wrote: > > Hi Alfred, > > > you might as well unconditionally include sys/socket.h and let it's > > internal #ifndef take care of that problem. > > you're right and i'll change it > > > I'm not sure why you don't just make your own new header file for > > this struct unless you're adding to an existing structure in > > socket.h, even if you are you can put whatever it is that you added > > to netinet/in.h into a seperate header or sys/socket.h itself. > > The reason is that the structures, socket options have to be in > whenever is included, since that's what's specified by > that draft (which is good for portable code). So effectively the standard mandates this? You might as well get rid of netinet/in.h then and include it all in sys/socket.h... or... wrap your stuff in sys/socket.h like so: #ifdef _NETINET_IN_H_ /* stuff that depends on netinet/in.h */ #endif -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message