From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 13 17:26:50 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id D25521065679;
	Wed, 13 Jul 2011 17:26:50 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Stephen Montgomery-Smith <stephen@missouri.edu>
Date: Wed, 13 Jul 2011 13:26:42 -0400
User-Agent: KMail/1.6.2
References: <201107121826.00020.jkim@FreeBSD.org>
	<4E1DD013.4050107@missouri.edu>
	<201107131323.46842.jkim@FreeBSD.org>
In-Reply-To: <201107131323.46842.jkim@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201107131326.44111.jkim@FreeBSD.org>
Cc: Pav Lucistnik <pav@FreeBSD.org>,
	Stephen Montgomery-Smith <stephen@FreeBSD.org>, freebsd-ports@FreeBSD.org
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2011 17:26:51 -0000

On Wednesday 13 July 2011 01:23 pm, Jung-uk Kim wrote:
> On Wednesday 13 July 2011 01:04 pm, Stephen Montgomery-Smith wrote:
> > On 07/13/2011 11:59 AM, Stephen Montgomery-Smith wrote:
> > > But code like this seems simpler than my original suggestion:
> > >
> > > if (echo "$$4" | grep -E [^[:alnum:]_-]>  /dev/null); then echo
> > > \ ${ECHO_MSG} "blah blah."; \
> > > 	exit 1; \
> > > fi; \
> > > pathname="${DESKTOPDIR}/$$4";
> >
> > Oh, and use ${GREP} and ${ECHO_CMD} instead of echo and grep. 
> > And maybe the "-E" is unnecessary.
>
> If we actually do "exit 1;", I'd prefer something like that, too.

Actually, this must be moved to 'check-desktop-entries' target, I 
believe.

Jung-uk Kim