Date: Wed, 13 Jul 2011 13:26:42 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Stephen Montgomery-Smith <stephen@missouri.edu> Cc: Pav Lucistnik <pav@FreeBSD.org>, Stephen Montgomery-Smith <stephen@FreeBSD.org>, freebsd-ports@FreeBSD.org Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES Message-ID: <201107131326.44111.jkim@FreeBSD.org> In-Reply-To: <201107131323.46842.jkim@FreeBSD.org> References: <201107121826.00020.jkim@FreeBSD.org> <4E1DD013.4050107@missouri.edu> <201107131323.46842.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 13 July 2011 01:23 pm, Jung-uk Kim wrote:
> On Wednesday 13 July 2011 01:04 pm, Stephen Montgomery-Smith wrote:
> > On 07/13/2011 11:59 AM, Stephen Montgomery-Smith wrote:
> > > But code like this seems simpler than my original suggestion:
> > >
> > > if (echo "$$4" | grep -E [^[:alnum:]_-]> /dev/null); then echo
> > > \ ${ECHO_MSG} "blah blah."; \
> > > exit 1; \
> > > fi; \
> > > pathname="${DESKTOPDIR}/$$4";
> >
> > Oh, and use ${GREP} and ${ECHO_CMD} instead of echo and grep.
> > And maybe the "-E" is unnecessary.
>
> If we actually do "exit 1;", I'd prefer something like that, too.
Actually, this must be moved to 'check-desktop-entries' target, I
believe.
Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107131326.44111.jkim>