From owner-svn-src-all@freebsd.org  Mon Jan  4 03:34:23 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D80FFA60009;
 Mon,  4 Jan 2016 03:34:23 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AB44715D7;
 Mon,  4 Jan 2016 03:34:23 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u043YMKg010675;
 Mon, 4 Jan 2016 03:34:22 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u043YM2p010674;
 Mon, 4 Jan 2016 03:34:22 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201601040334.u043YM2p010674@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Garrett Cooper <ngie@FreeBSD.org>
Date: Mon, 4 Jan 2016 03:34:22 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r293135 - head/lib/libnv/tests
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2016 03:34:23 -0000

Author: ngie
Date: Mon Jan  4 03:34:22 2016
New Revision: 293135
URL: https://svnweb.freebsd.org/changeset/base/293135

Log:
  Remove free'ing of an uninitialized variable
  
  Just remove it completely from the test as it's initialized but unused apart
  from the free(3) call
  
  Differential Revision: https://reviews.freebsd.org/D4769 (part of larger diff)
  MFC after: 5 days
  Reported by: cppcheck
  Reviewed by: oshogbo
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/lib/libnv/tests/nv_array_tests.cc

Modified: head/lib/libnv/tests/nv_array_tests.cc
==============================================================================
--- head/lib/libnv/tests/nv_array_tests.cc	Mon Jan  4 03:26:36 2016	(r293134)
+++ head/lib/libnv/tests/nv_array_tests.cc	Mon Jan  4 03:34:22 2016	(r293135)
@@ -1101,7 +1101,6 @@ ATF_TEST_CASE_BODY(nvlist_nvlist_array__
 {
 	nvlist_t *testnvl[8], *unpacked;
 	const nvlist_t * const *const_result;
-	nvlist_t **result;
 	nvlist_t *nvl;
 	size_t num_items, packed_size;
 	unsigned int i;
@@ -1159,7 +1158,6 @@ ATF_TEST_CASE_BODY(nvlist_nvlist_array__
 
 	for (i = 0; i < nitems(testnvl); i++)
 		nvlist_destroy(testnvl[i]);
-	free(result);
 	nvlist_destroy(nvl);
 	nvlist_destroy(unpacked);
 	free(packed);