From owner-cvs-src@FreeBSD.ORG Tue Dec 7 09:35:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBF2F16A4CE; Tue, 7 Dec 2004 09:35:13 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 121A543D4C; Tue, 7 Dec 2004 09:35:13 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iB79Z6PE080332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 7 Dec 2004 12:35:06 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iB79Z5pW076198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Dec 2004 12:35:05 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iB79Z5nJ076197; Tue, 7 Dec 2004 12:35:05 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Tue, 7 Dec 2004 12:35:04 +0300 From: Gleb Smirnoff To: SUZUKI Shinsuke , ru@freebsd.org Message-ID: <20041207093504.GA75987@cell.sick.ru> References: <200412061902.iB6J2hJ6000543@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet in_gif.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2004 09:35:14 -0000 On Tue, Dec 07, 2004 at 02:03:02PM +0900, SUZUKI Shinsuke wrote: S> - you need the same fix to sys/netinet6/in6_gif.c (for IPv4 over IPv6 S> tunnel) S> S> - it seems like sys/net/if_stf.c also needs the similar fix S> (I haven't confirmed it though, I'll check it later) S> S> - Here's a patch to update route cache periodically, to prevent S> unexpected gif failure due to a stale route cache. Is it okay to S> commit it together with your change? The only reasonable value for in_gif_rtcachettl would be 1 second. I don't think a 300 second lag in network is acceptable for us. Even 5 second lag is not. I admit that my fix is dirty and should be reworked. I like Ruslan's idea. We should reallocate route every time when routing table age changes. This does not happen too often, and this will give us ability to switch to a new route as fast as possible with zero packet loss. As soon as Ruslan commits route table aging, I will fix in_gif and in6_gif.c and look at other tunnels. I'll send both of you patches for review. P.S. I've written to net@ a week ago. Why do I get review only after change is commited? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE