Date: Fri, 21 Dec 2018 18:16:11 -1000 (-10) From: Gerald Pfeifer <gerald@pfeifer.com> To: Tobias Kortkamp <tobik@freebsd.org> Cc: Yuri Victorovich <yuri@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487866 - head/sysutils/xorriso Message-ID: <alpine.LSU.2.21.1812211322180.3662@anthias.pfeifer.com> In-Reply-To: <20181220094013.GA24592@frea.tobik.me> References: <201812200852.wBK8qZm1076469@repo.freebsd.org> <20181220094013.GA24592@frea.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 20 Dec 2018, Tobias Kortkamp wrote:
>> Author: yuri
>> Date: Thu Dec 20 08:52:35 2018
>> New Revision: 487866
> This isn't right. A new file is installed, so a PORTREVISION bump
> is required. It should be added as INFO (or TK_INFO since it appears
> to be optional similar to xorriso-tcltk.1.gz) to the port if it's
> really needed so that indexinfo is called after install.
>
> The port already has that and also has do-install-TK-off which
> deletes it from STAGEDIR but the info path was not adjusted in
> r484628 when ${PREFIX}/info was moved to ${PREFIX}/share/info.
I see that Yuri applied a follow-up patch based on your feedback,
but would do you think about the following?
>From Mk/bsd.ports.mk:
# INFO_PATH - Path, where all .info files will be installed by your
# port, relative to ${PREFIX}
And:
INFO_PATH?= share/info
Okay to apply the little patch below?
Gerald
Index: sysutils/xorriso/Makefile
===================================================================
--- sysutils/xorriso/Makefile (revision 488030)
+++ sysutils/xorriso/Makefile (working copy)
@@ -51,7 +51,7 @@
do-install-TK-off:
${RM} ${STAGEDIR}${PREFIX}/bin/xorriso-tcltk \
${STAGEDIR}${PREFIX}/man/man1/xorriso-tcltk.1.gz \
- ${STAGEDIR}${PREFIX}/share/info/xorriso-tcltk.info
+ ${STAGEDIR}${PREFIX}/${INFO_PATH}/xorriso-tcltk.info
do-install-DOCS-on:
@${MKDIR} ${STAGEDIR}${DOCSDIR}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1812211322180.3662>