From owner-svn-ports-all@freebsd.org Sat Dec 22 04:16:25 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1D3313439AF; Sat, 22 Dec 2018 04:16:25 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E8E696ECA0; Sat, 22 Dec 2018 04:16:24 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 0D4F233E70; Fri, 21 Dec 2018 23:16:18 -0500 (EST) Received: from [192.168.0.6] (147.171.185.203.dsl.dyn.mana.pf [203.185.171.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 5451233E6F; Fri, 21 Dec 2018 23:16:16 -0500 (EST) Date: Fri, 21 Dec 2018 18:16:11 -1000 (-10) From: Gerald Pfeifer To: Tobias Kortkamp cc: Yuri Victorovich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487866 - head/sysutils/xorriso In-Reply-To: <20181220094013.GA24592@frea.tobik.me> Message-ID: References: <201812200852.wBK8qZm1076469@repo.freebsd.org> <20181220094013.GA24592@frea.tobik.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: E8E696ECA0 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=softfail (mx1.freebsd.org: 209.68.5.143 is neither permitted nor denied by domain of gerald@pfeifer.com) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-4.09 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.11)[ip: (-4.41), ipnet: 209.68.0.0/18(-0.55), asn: 7859(-0.51), country: US(-0.08)]; MX_GOOD(-0.01)[mailwash29.pair.com]; NEURAL_HAM_SHORT(-0.87)[-0.869,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 04:16:26 -0000 On Thu, 20 Dec 2018, Tobias Kortkamp wrote: >> Author: yuri >> Date: Thu Dec 20 08:52:35 2018 >> New Revision: 487866 > This isn't right. A new file is installed, so a PORTREVISION bump > is required. It should be added as INFO (or TK_INFO since it appears > to be optional similar to xorriso-tcltk.1.gz) to the port if it's > really needed so that indexinfo is called after install. > > The port already has that and also has do-install-TK-off which > deletes it from STAGEDIR but the info path was not adjusted in > r484628 when ${PREFIX}/info was moved to ${PREFIX}/share/info. I see that Yuri applied a follow-up patch based on your feedback, but would do you think about the following? >From Mk/bsd.ports.mk: # INFO_PATH - Path, where all .info files will be installed by your # port, relative to ${PREFIX} And: INFO_PATH?= share/info Okay to apply the little patch below? Gerald Index: sysutils/xorriso/Makefile =================================================================== --- sysutils/xorriso/Makefile (revision 488030) +++ sysutils/xorriso/Makefile (working copy) @@ -51,7 +51,7 @@ do-install-TK-off: ${RM} ${STAGEDIR}${PREFIX}/bin/xorriso-tcltk \ ${STAGEDIR}${PREFIX}/man/man1/xorriso-tcltk.1.gz \ - ${STAGEDIR}${PREFIX}/share/info/xorriso-tcltk.info + ${STAGEDIR}${PREFIX}/${INFO_PATH}/xorriso-tcltk.info do-install-DOCS-on: @${MKDIR} ${STAGEDIR}${DOCSDIR}