From owner-cvs-ports@FreeBSD.ORG  Tue Aug 16 00:11:10 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AADDF106564A;
	Tue, 16 Aug 2011 00:11:10 +0000 (UTC)
	(envelope-from swills@FreeBSD.org)
Received: from mouf.net (mouf.net [204.109.58.86])
	by mx1.freebsd.org (Postfix) with ESMTP id 62C4C8FC08;
	Tue, 16 Aug 2011 00:11:10 +0000 (UTC)
Received: from meatwad.mouf.net (cpe-065-190-149-241.nc.res.rr.com
	[65.190.149.241]) (authenticated bits=0)
	by mouf.net (8.14.4/8.14.4) with ESMTP id p7G0B5oO080994
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256
	verify=NOT); Mon, 15 Aug 2011 20:11:07 -0400 (EDT)
	(envelope-from swills@FreeBSD.org)
Message-ID: <4E49B599.1040803@FreeBSD.org>
Date: Mon, 15 Aug 2011 20:11:05 -0400
From: Steve Wills <swills@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.17) Gecko/20110531 Thunderbird/3.1.10
MIME-Version: 1.0
To: Sahil Tandon <sahil@FreeBSD.org>
References: <201108152121.p7FLLfhS098668@repoman.freebsd.org>
	<20110815224433.GC256@magic.hamla.org>
In-Reply-To: <20110815224433.GC256@magic.hamla.org>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(mouf.net [204.109.58.86]); Mon, 15 Aug 2011 20:11:07 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.96.2 at mouf.net
X-Virus-Status: Clean
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/Tools/scripts addport
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2011 00:11:10 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/15/11 18:44, Sahil Tandon wrote:
> On Mon, 2011-08-15 at 21:21:41 +0000, Steve Wills wrote:
> 
> [ .. ]
> 
>>   - Add check that port is in right directory as I've been bitten by
>>   this
> 
> This looks wrong.  Try adding a port as described in EXAMPLES, and it
> errors out with something similar to:
> 
>  % ./addport -n -d foo 
>  Working with port directory /usr/home/sahil/my_wrkdir/ports/mail/foo.
>  ./addport: Port category mail doesn't match dir foo !
> 

Ah, you're right, I didn't account for that usage. Reverted for now. I
may still try to find a way to check the dir if that's not considered a
bad idea in general (as opposed to the implementation being bad, which
it clearly was). Anyway, sorry about that, thanks for catching it.

Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQEcBAEBAgAGBQJOSbWZAAoJEPXPYrMgexuhCBIH+weHPKtFqQ74L50fp9GMM86A
N/csF9/4wc7O6WRwRBXGsqufz7Ufb/IFpncsrRhj+/10YSyn+haF0OFP/4n2KUYk
TDzbo2NPEFaLaottRrKNXComf2WeW6SEIap8MhdAgyRfNgOoldbC2g4raacf0ERM
xheNGOp4P2dEGuVVeuaADj9EnxFVkwat8npwvdaZTWkFudH4imvFFlDy+SLaO5yK
nAQGU7eTcg07wuV8uEVOH59tdDdxHefAi6+HpXuS+3XuWlf0+On/MYkIMFzIfRjb
0sFf7prvCHSgU9iM/50WHaSlpzBbfwNuteaup+Z1swssMF0me5ST2O74mNC/TS8=
=ymmS
-----END PGP SIGNATURE-----