From owner-freebsd-current Mon Feb 10 4:41:57 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A9F737B401 for ; Mon, 10 Feb 2003 04:41:56 -0800 (PST) Received: from castle.jp.FreeBSD.org (castle.jp.FreeBSD.org [210.226.20.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B04E43F3F for ; Mon, 10 Feb 2003 04:41:55 -0800 (PST) (envelope-from matusita@jp.FreeBSD.org) Received: from localhost (localhost [::1]) by castle.jp.FreeBSD.org (8.11.6+3.4W/8.11.3) with ESMTP/inet6 id h1ACfrJ36073 for ; Mon, 10 Feb 2003 21:41:53 +0900 (JST) (envelope-from matusita@jp.FreeBSD.org) X-User-Agent: Mew/1.94.2 XEmacs/21.5 (bamboo) X-FaceAnim: (-O_O-)(O_O- )(_O- )(O- )(- -)( -O)( -O_)( -O_O)(-O_O-) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Dispatcher: imput version 20000228(IM140) Lines: 39 From: Makoto Matsushita To: current@FreeBSD.org Subject: Comments welcome: 1-line patch: teach FTP_PASSIVE_MODE to ${CHROOT}/mk Date: Mon, 10 Feb 2003 21:41:51 +0900 Message-Id: <20030210214151H.matusita@jp.FreeBSD.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I'd like to commit following patch to src/release/Makefile. Here's background: A user may want to build their own FreeBSD distribution. During the release build, pkg_add(1) runs within chroot sandbox to install mkisofs(8) iff MAKE_ISOS=YES. Imagine what's happen if the user is living behind the Internet firewall -- pkg_add(1) try to fetch the package from outside but it can't since firewall usually doesn't allow outer-to-inner connections. According to the pkg_add(1) manpage, FTP_PASSIVE_MODE environment variable enables passive ftp connections. You know there are many solutions about this issue. IIRC, it can be easily fixed with "passing FTP_PASSIVE_MODE variable to the chroot sandbox." Following patch was tested on FreeBSD/i386, and it should work on other archs since this is arch-independent code. If there's no problem around, I'll commit it later. Any comments and/or suggestions are welcome. -- - Makoto `MAR' Matsushita Index: Makefile =================================================================== RCS file: /home/ncvs/src/release/Makefile,v retrieving revision 1.749 diff -u -r1.749 Makefile --- Makefile 4 Feb 2003 16:07:20 -0000 1.749 +++ Makefile 10 Feb 2003 11:19:41 -0000 @@ -430,6 +430,7 @@ DOMINIMALDOCPORTS \ EXTRA_SRC \ FIXCRYPTO \ + FTP_PASSIVE_MODE \ KERNELS \ KERNEL_FLAGS \ MAKE_ISOS \ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message