From owner-freebsd-hackers@freebsd.org Sat Apr 21 20:50:26 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDE2FFA2BCC for ; Sat, 21 Apr 2018 20:50:25 +0000 (UTC) (envelope-from 01000162e9f8cc9a-4ffd1c10-d640-47b0-bfae-6769dff4f78b-000000@amazonses.com) Received: from a8-13.smtp-out.amazonses.com (a8-13.smtp-out.amazonses.com [54.240.8.13]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E5337198E for ; Sat, 21 Apr 2018 20:50:25 +0000 (UTC) (envelope-from 01000162e9f8cc9a-4ffd1c10-d640-47b0-bfae-6769dff4f78b-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=dqtolf56kk3wpt62c3jnwboqvr7iedax; d=tarsnap.com; t=1524343819; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=/RAWw1NA4v0ocZPOOpP50kh4MMUsy6lLwHjoYJOgL7w=; b=AnMZVT/xsVCd64foEQpuznINsjSn5GyRahHUsV97j62derecig18qqqIIwupN7Pk nF2hR0xjipBdqUO/d9a49Ja/1YUwmBgp9pnZ2/POmY0r5WtfYbR/lmCW2x60kGoqDpE m7NZaQ1lOLcA1xv8uBDKfovQd+GVY7fs/fBBYNuA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1524343819; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=/RAWw1NA4v0ocZPOOpP50kh4MMUsy6lLwHjoYJOgL7w=; b=JBwEUz/IpWkVl0qvMIFM49SXedZ5+p8TmF4PNTN++0bJAI1xKv45gAUAsgTyrZDM kwnOCTn6o5mtBP2llIr7PH7mlRGf32AWtmYLIT3nJbFDGQUwgNScJb1O2fiFvXHJenG /k6ME5PRHTqKnRVPxDD2mUBaKvJOxE+WBX5YwMzw= Subject: Re: RFC: Hiding per-CPU kernel output behind bootverbose To: Warner Losh Cc: gljennjohn@gmail.com, Konstantin Belousov , "freebsd-hackers@freebsd.org" , Conrad Meyer References: <01000162df15f856-1e5d2641-2a72-4250-8d8e-adcd47bc5db4-000000@email.amazonses.com> <20180419204405.GE6887@kib.kiev.ua> <20180419214550.GF6887@kib.kiev.ua> <01000162e58a466e-98f0305b-1723-467a-bc49-342c3fa9fc5b-000000@email.amazonses.com> <20180421092049.GM6887@kib.kiev.ua> <20180421123544.56d7e690@ernst.home> <01000162e9e66255-b8ae47df-b48c-4512-a042-48df5604914b-000000@email.amazonses.com> From: Colin Percival Openpgp: preference=signencrypt Autocrypt: addr=cperciva@tarsnap.com; prefer-encrypt=mutual; keydata= xsDhBElrAAcRBACDfDys4ZtK+ErCJ1HAzYeteKpm3OEsvT/49AjUTLihkF79HhIKrCQU+1KC zv7BwHCMLb6hq30As9L7iFKG7n5QFLFC4Te/VcITUnWHMG/c3ViLOfJGvi+9/nOEHaM1dVJY D6tEp5yM1nHmVQpo9932j4KGuGFR0LhOK5IHXOSfGwCgxSFDPdgxe2OEjWxjGgY+oV3EafcD +JROXCTjlcQiG/OguQH4Vks3mhHfFnEppLxTkDuYgHZQiUtpcT9ssH5khgqoTyMar05OUdAj ZIhNbWDh4LgTj+7ZmvLhXT5Zxw8LX9d7T36aTB8XDQSenDqEtinMWOb0TCBBLbsB8EFG1WTT ESbZci9jJS5yhtktuZoY/eM8uXMD/3k4FWFO80VRRkELSp+XSy/VlSQjyi/rhl2nQq/oOA9F oJbDaB0yq9VNhxP+uFBzBWSqeIX0t1ZWLtNfVFr4TRP5hihI5ICrg/0OpqgisKsU2NFe9xyO hyJLYmfD8ebpDJ/9k30C7Iju9pVrwLm1QgS4S2fqJRcR+U4WbjvP7CgSzSVDb2xpbiBQZXJj aXZhbCA8Y3BlcmNpdmFAdGFyc25hcC5jb20+wmEEExECACEFAklrALYCGwMHCwkIBwMCAQQV AggDBBYCAwECHgECF4AACgkQOM7KaQxqam6/igCgn+z2k3V5ggNppmWrZstt1U2lugsAoL7L wS9V9yLtil3oWmHtwpUqYruEzsFNBElrAAcQCAD3ZLMIsP4CIDoJORg+YY0lqLVBgcnF7pFb 4Uy2+KvdWofN+DKH61rZLjgXXkNE9M4EQC1B4lGttBP8IY2gs41y3AUogGdyFbidq99rCBz7 LTsgARHwFxZoaHmXyiZLEU1QZuMqwPZV1mCviRhN5E3rRqYNXVcrnXAAuhBpvNyj/ntHvcDN 2/m+ochiuBYueU4kX3lHya7sOj+mTsndcWmQ9soOUyr8O0r/BG088bMn4qqtUw4dl5/pglXk jbl7uOOPinKf0WVd2r6M0wLPJCD4NPHrCWRLLLAjwfjrtoSRvXxDbXhCdgGBa72+K8eYLzVs hgq7tJOoBWzjVK6XRxR7AAMGB/9Mo3iJ2DxqDecd02KCB5BsFDICbJGhPltU7FwrtbC7djSb XUrwsEVLHi4st4cbdGNCWCrp0BRezXZKohKnNAPFOTK++ZfgeKxrV2sJod+Q9RILF86tQ4XF 7A7Yme5hy92t/WgiU4vc/fWbgP8gV/19f8nunaT2E9NSa70mZFjZNu4iuwThoUUO5CV3Wo0Y UISsnRK8XD1+LR3A2qVyLiFRwh/miC1hgLFCTGCQ3GLxZeZzIpYSlGdQJ0L5lixW5ZQD9r1I 8i/8zhE6qRFAM0upUMI3Gt1Oq2w03DiXrZU0Fu/R8Rm8rlnkQKA+95mRTUq1xL5P5NZIi4gJ Z569OPMFwkkEGBECAAkFAklrAAcCGwwACgkQOM7KaQxqam41igCfbaldnFTu5uAdrnrghESv EI3CAo8AoLkNMks1pThl2BJNRm4CtTK9xZeH Message-ID: <01000162e9f8cc9a-4ffd1c10-d640-47b0-bfae-6769dff4f78b-000000@email.amazonses.com> Date: Sat, 21 Apr 2018 20:50:19 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SES-Outgoing: 2018.04.21-54.240.8.13 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Apr 2018 20:50:26 -0000 On 04/21/18 13:35, Warner Losh wrote: > diff --git a/sys/x86/x86/mp_x86.c b/sys/x86/x86/mp_x86.c > index 3fcf7aa25152..4637243c4274 100644 > --- a/sys/x86/x86/mp_x86.c > +++ b/sys/x86/x86/mp_x86.c > @@ -1020,7 +1020,8 @@ init_secondary_tail(void) >         smp_cpus++; > >         CTR1(KTR_SMP, "SMP: AP CPU #%d Launched", cpuid); > -       printf("SMP: AP CPU #%d Launched!\n", cpuid); > +       printf("%s%d%s", smp_cpus == 1 ? "Launching APs: " : "", > +           cpuid, smp_cpus == mp_ncpus ? "\n" : " "); Have you tested this? If you're going to print the header here, I think you need to check for smp_cpus == 2, since it starts at 1 and is already incremented once. (Because CPU #0 isn't an AP and thus doesn't hit this code path.) > which will print the results one at a time. Except when PRINTF_BUFR_SIZE is > defined (which is in the GENERIC config). Do you have it in the kernel you're > booting in the cloud? I'm running GENERIC + options TSLOG, and (with a 500 ms delay added) I could definitely see the individual numbers showing up one by one on the VGA output. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid