Date: Mon, 9 Apr 2012 18:51:50 +0200 From: Robert Millan <rmh@freebsd.org> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@freebsd.org, Steven Chamberlain <steven@pyro.eu.org> Subject: Re: [PATCH] Abort powerd when no cpufreq(4) support is found Message-ID: <CAOfDtXPW8ipGE5p=76HQ5pe9wGx0u%2BKYddRYN26pMW6O7wtENA@mail.gmail.com> In-Reply-To: <E2E769FA-970A-4E1C-805B-DE6397B456C9@root.org> References: <CAOfDtXO=7ALiBVHdY-hHa158yXoM%2BXXigkU4SObPHRr0h-2iUQ@mail.gmail.com> <E2E769FA-970A-4E1C-805B-DE6397B456C9@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--f46d0447a259a04f9a04bd41d25e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Nate, El 9 d=E2=80=99abril de 2012 18:06, Nate Lawson <nate@root.org> ha escrit: > The message is fine, but I think an error code of 0 is wrong. Powerd didn= 't start, whereas 0 means the daemon launched successfully. In that case, may I suggest that we return one of the error codes recommended by sysexists(3)? EX_UNAVAILABLE seems close enough to the reason we're aborting. --=20 Robert Millan --f46d0447a259a04f9a04bd41d25e Content-Type: application/octet-stream; name="no_cpufreq.diff" Content-Disposition: attachment; filename="no_cpufreq.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h0trbxbh0 SW5kZXg6IHVzci5zYmluL3Bvd2VyZC9wb3dlcmQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3Iuc2Jpbi9w b3dlcmQvcG93ZXJkLmMJKHJldmlzaW9uIDIzNDA1MykKKysrIHVzci5zYmluL3Bvd2VyZC9wb3dl cmQuYwkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsNyBAQAogI2luY2x1ZGUgPHN0ZGlvLmg+ CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CisjaW5jbHVkZSA8c3lz ZXhpdHMuaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KIAogI2lmZGVmIF9faTM4Nl9fCkBAIC01MzYs NyArNTM3LDcgQEAKIAkJZXJyKDEsICJsb29rdXAga2Vybi5jcF90aW1lcyIpOwogCWxlbiA9IDQ7 CiAJaWYgKHN5c2N0bG5hbWV0b21pYigiZGV2LmNwdS4wLmZyZXEiLCBmcmVxX21pYiwgJmxlbikp Ci0JCWVycigxLCAibG9va3VwIGZyZXEiKTsKKwkJZXJyKEVYX1VOQVZBSUxBQkxFLCAibm8gY3B1 ZnJlcSg0KSBzdXBwb3J0IC0tIGFib3J0aW5nIik7CiAJbGVuID0gNDsKIAlpZiAoc3lzY3RsbmFt ZXRvbWliKCJkZXYuY3B1LjAuZnJlcV9sZXZlbHMiLCBsZXZlbHNfbWliLCAmbGVuKSkKIAkJZXJy KDEsICJsb29rdXAgZnJlcV9sZXZlbHMiKTsK --f46d0447a259a04f9a04bd41d25e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXPW8ipGE5p=76HQ5pe9wGx0u%2BKYddRYN26pMW6O7wtENA>