From owner-svn-src-all@freebsd.org Tue Jul 5 10:08:50 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51746B21729; Tue, 5 Jul 2016 10:08:50 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id 1C3B81D6A; Tue, 5 Jul 2016 10:08:49 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c110-21-100-149.carlnfd1.nsw.optusnet.com.au [110.21.100.149]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 459041A519B; Tue, 5 Jul 2016 20:08:42 +1000 (AEST) Date: Tue, 5 Jul 2016 20:08:42 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Konstantin Belousov cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302328 - in head/sys: kern sys In-Reply-To: <201607031819.u63IJm79075708@repo.freebsd.org> Message-ID: <20160705200552.Y1821@besplex.bde.org> References: <201607031819.u63IJm79075708@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=EfU1O6SC c=1 sm=1 tr=0 a=XDAe9YG+7EcdVXYrgT+/UQ==:117 a=XDAe9YG+7EcdVXYrgT+/UQ==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=kj9zAlcOel0A:10 a=RtYHprBuA76D4Ga1t8EA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 10:08:50 -0000 On Sun, 3 Jul 2016, Konstantin Belousov wrote: This is mostly a test reply (replying to src-committers has stopped working for newer commits). > Log: > Provide helper macros to detect 'non-silent SBDRY' state and to > calculate appropriate return value for stops. Simplify the code by > using them. > > Fix typo in sig_suspend_threads(). The thread which sleep must be > aborted is td2. (*) > > In issignal(), when handling stopping signal for thread in > TD_SBDRY_INTR state, do not stop, this is wrong and fires assert. > This is yet another place where execution should be forced out of > SBDRY-protected region. For such case, return -1 from issignal() and > translate it to corresponding error code in sleepq_catch_signals(). > Assert that other consumers of cursig() are not affected by the new > return value. (*) > > Micro-optimize, mostly VFS and VOP methods, by avoiding calling the > functions when SIGDEFERSTOP_NOP non-change is requested. (**) > > Reported and tested by: pho (*) > Requested by: bde (**) > Sponsored by: The FreeBSD Foundation > MFC after: 2 weeks > Approved by: re (gjb) Thanks, but this is still very slow (even slower than beore the micro-optimization). Bruce