From owner-freebsd-current Mon Aug 13 15:14:33 2001 Delivered-To: freebsd-current@freebsd.org Received: from Veronica.wmol.com (veronica.wmol.com [208.242.83.241]) by hub.freebsd.org (Postfix) with ESMTP id A982A37B418 for ; Mon, 13 Aug 2001 15:14:30 -0700 (PDT) (envelope-from david@phobia.ms) Received: from rain.hill.hom (081bc122.chartermi.net [24.247.81.122]) by Veronica.wmol.com (Vircom SMTPRS 5.0.193) with ESMTP id ; Mon, 13 Aug 2001 18:12:28 -0400 Date: Mon, 13 Aug 2001 18:14:01 -0400 From: David Hill To: David Hill Cc: current@FreeBSD.ORG Subject: Re: write.c patch (WARNS 2) Message-Id: <20010813181401.6cfd1670.david@phobia.ms> In-Reply-To: <20010810230649.756d5c71.david@phobia.ms> References: <20010810230649.756d5c71.david@phobia.ms> X-Mailer: Sylpheed version 0.5.2 (GTK+ 1.2.10; i386-unknown-freebsd5.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 10 Aug 2001 23:06:49 -0400 David Hill wrote: > Hello - > Here is my patch to make write.c work when WARNS=2. I also did some code cleanup > > 1. Constify > 2. Changed a strncpy to strlcpy > 3. Changed (S_IWRITE >> 3) to S_IWGRP > 4. Cleaned up 2 pieces of code (declaration and unused variable) when WARNS=2 is set. > > - David > Could someone please review this patch and comment on it? Thank you - David To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message