From owner-freebsd-current@freebsd.org Mon May 23 22:41:10 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64535B47B9B for ; Mon, 23 May 2016 22:41:10 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-211-168.reflexion.net [208.70.211.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A35D1235 for ; Mon, 23 May 2016 22:41:09 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 31412 invoked from network); 23 May 2016 21:41:38 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 23 May 2016 21:41:38 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v7.90.3) with SMTP; Mon, 23 May 2016 17:41:06 -0400 (EDT) Received: (qmail 7591 invoked from network); 23 May 2016 21:41:06 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with SMTP; 23 May 2016 21:41:06 -0000 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.8] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id BE0051C43E2; Mon, 23 May 2016 14:41:03 -0700 (PDT) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: Re: WITH_SYSTEM_COMPILER: Skip Clang/GCC bootstrap [Critical note for Toolchain changes] Message-Id: <986EF3DE-84DA-4867-AD94-384EA3733144@dsl-only.net> Date: Mon, 23 May 2016 14:41:07 -0700 To: FreeBSD Current , Bryan Drewery , FreeBSD Toolchain Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 22:41:10 -0000 Relative to (Bryan Drewery Mon May 23 16:40:23 UTC 2016): > A critical note to toolchain developers, or anyone who touches the = Clang > or GCC source files. If you modify these files or add a new target > architecture into Clang, please bump the revision in the appropriate = file: >=20 > Clang: lib/clang/include/clang/Basic/Version.inc FREEBSD_CC_VERSION > GCC: gnu/usr.bin/cc/cc_tools/freebsd-native.h FBSD_CC_VER quoting from https://svnweb.freebsd.org/changeset/base/300354 : > This relies on the macros being incremented whenever any change occurs > to these compilers that warrant rebuilding files. It also should = never > repeat earlier values. It appears that someone that tries to make or test clang patches without = using a committer bit to be the one updating the official source will = have trouble meeting this criteria. I've been in that situation in the = past. Reverting back to, say, CURRENT after a patch is adopted is = another example of version number progression problems. It may be that official value updates to FREEBSD_CC_VERSION should be = spaced apart leaving versions available between official version numbers = for such local activities without version identification conflicts. There are also projects such as the /project/clang*-import ones that = might have version number transition issues between it and CURRENT at = various stages for those working on the project and anyone that is just = following the project while it is active. I followed clang380-import and = reported on some powerpc64/powerpc/armv6 issues during the project so = I've been in this situation in the past. It is not clear to me what the right things would have been to do and = when to do it if this FREEBSD_CC_VERSION criteria had been in place at = the time. Similar comments probably apply to FBSD_CC_VER and gcc/g++. Is it as simple as "never use WITH_SYSTEM_COMPILER" for patch/update = explorations that are not yet official commits on CURRENT or STABLE? = Does the version number involved then matter? =3D=3D=3D Mark Millard markmi@dsl-only.net