Date: Wed, 10 Apr 2013 01:00:03 GMT From: Golyashov Sergey <svvord@ulona.org> To: gnome@FreeBSD.org Subject: Re: ports/177462: graphics/dia: dia-0.97.2,1 fails to start Message-ID: <201304100100.r3A103pL096460@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/177462; it has been noted by GNATS.
From: Golyashov Sergey <svvord@ulona.org>
To: bug-followup@freebsd.org
Cc:
Subject: Re: ports/177462: graphics/dia: dia-0.97.2,1 fails to start
Date: Wed, 10 Apr 2013 11:51:01 +1100
This is a multi-part message in MIME format.
--nextPart1820332.NJNNWAKDiQ
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
"glib.h" not include "glib/gstdio.h". But "glib/gstdio.h" declares a function g_fopen. Without this declare g_fopen returns integer.
My test compile:
test.c:12:4: warning: incompatible integer to pointer conversion assigning to 'FILE *' (aka 'struct __sFILE *') from 'int' [-Wint-conversion]
f = g_fopen("test.txt", "rb");
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
Final patch for port attached to this message.
Regards.
Sergey Golyashov
--nextPart1820332.NJNNWAKDiQ
Content-Disposition: attachment; filename="dia.diff"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="utf-8"; name="dia.diff"
--- Makefile.orig 2013-04-10 11:03:22.536612689 +1100
+++ Makefile 2013-04-10 11:03:35.365611423 +1100
@@ -60,7 +60,6 @@
@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
${WRKSRC}/lib/intl.c
@${REINPLACE_CMD} -e 's|glib/.*\.h>|glib.h>|g' \
- ${WRKSRC}/objects/custom/shape_typeinfo.c \
${WRKSRC}/tests/test-objects.c \
${WRKSRC}/tests/test-boundingbox.c
.if defined(NOPORTDOCS)
--- files/patch-shape_typeinfo.c 2013-04-10 11:35:15.720611354 +1100
+++ files/patch-shape_typeinfo.c 2013-04-10 11:35:15.720719000 +1100
@@ -0,0 +1,10 @@
+--- objects/custom/shape_typeinfo.c.orig 2013-04-10 11:22:56.598611165 +1100
++++ objects/custom/shape_typeinfo.c 2013-04-10 11:23:18.888611303 +1100
+@@ -27,6 +27,6 @@
+ #include "custom_util.h"
+ #include <string.h>
+ #include <stdarg.h>
+-#include <glib/gstrfuncs.h>
++#include <glib.h>
+ #include <glib/gstdio.h>
+ #include <libxml/parser.h>
--nextPart1820332.NJNNWAKDiQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304100100.r3A103pL096460>