From owner-freebsd-arch@FreeBSD.ORG Tue Nov 1 21:55:51 2005 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D40816A41F; Tue, 1 Nov 2005 21:55:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1397543D48; Tue, 1 Nov 2005 21:55:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0561646B85; Tue, 1 Nov 2005 16:55:50 -0500 (EST) Date: Tue, 1 Nov 2005 21:55:49 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Nate Lawson In-Reply-To: <4367CF1E.2020809@root.org> Message-ID: <20051101215412.U18382@fledge.watson.org> References: <4366999B.4070005@root.org> <2BFF6EA7-F684-4DFB-8821-2DC5EBEB2181@FreeBSD.org> <4367CF1E.2020809@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: arch@FreeBSD.org, John Baldwin Subject: Re: KTR changes X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2005 21:55:51 -0000 On Tue, 1 Nov 2005, Nate Lawson wrote: >>> These should be merged the following under KTR_MALLOC (KTR_MEM?): >>> KTR_UMA: uma_zalloc_arg, uma_zfree_arg >>> KTR_VM: vmspace_alloc, vmspace_free, vm_map_create, vm_map_entry_unlink >> >> Well, I'm not sure about those as the KTR_VM ones aren't related >> to kernel malloc at all. vmspaces are the user virtual address >> mappings with vm_map being individual mappings. :) That's like >> saying that mmap() should be part of malloc(). :) I also think >> KTR_UMA is probably useful for getting a general feel for memory >> allocation activity in the kernel. > > What I'm trying to achieve is a general "KTR_MEMORY_STUFF" key. If > you're interested in allocations, getting info about mappings wouldn't > hurt either. I'm not entirely sure I agree -- I think combining malloc and zone allocation makes sense, but I think keeping vm tracking separate also makes sense, as one tends not to be interested in both VM pieces and explicit kernel allocation simultaneously. Just like one probably doesn't want VFS events and device driver operations at the same time -- you can combine them, but since both at the same time tend not to be desirable... :-) Robert N M Watson