From owner-svn-src-head@freebsd.org Tue Sep 3 14:06:33 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C346DC9A7; Tue, 3 Sep 2019 14:06:28 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zR2wTtz4PYq; Tue, 3 Sep 2019 14:06:27 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 620B71A6BC; Tue, 3 Sep 2019 14:06:08 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 6E51F2B61; Mon, 8 Apr 2019 08:35:52 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2362E8E6A2; Mon, 8 Apr 2019 08:35:52 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 120A32B5F; Mon, 8 Apr 2019 08:35:52 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id BAEEA2B5C; Mon, 8 Apr 2019 08:35:48 +0000 (UTC) (envelope-from crees@freebsd.org) Received: from mail37c50.megamailservers.eu (mail161c50.megamailservers.eu [91.136.10.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D19258E6A0; Mon, 8 Apr 2019 08:35:47 +0000 (UTC) (envelope-from crees@freebsd.org) X-Authenticated-User: bayofrum@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1554712539; bh=WXF6OKlWITD5nuKjiFt640aGyRQ/M/QSxizizgrzNvM=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=Fb0r+sB8QuGK7p81blFRcyrWZnT8tWTpb7QsejK6eTLPlxtYT15YhGnmeG39v3Fy6 DD8sGMpFVRXnHOjUfU7936DTwE0Pw/A0pe5Uuv16GVBn5Cq4Yj/mq7hkOoRey3aVb1 s9Scgmreo6hz/tLlXtk0dXzDlJk5jYF8SAMjuJTk= Feedback-ID: crees@freebsd.o Received: from pegasus.bayofrum.net (81-178-238-70.dsl.pipex.com [81.178.238.70]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x388ZbxH026876; Mon, 8 Apr 2019 08:35:39 +0000 Received: from www.bayofrum.net (unknown [192.168.1.70]) by pegasus.bayofrum.net (Postfix) with ESMTPA id B5360144D7; Mon, 8 Apr 2019 09:28:45 +0100 (BST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit From: Chris Rees To: Oliver Pinter CC: Warner Losh , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh , owner-svn-src-all@freebsd.org Subject: Re: svn commit: r346018 - head/sys/conf In-Reply-To: References: <201904071839.x37IduPO002007@repo.freebsd.org> Message-ID: <839b79cfabfc63d0077895575f317570@FreeBSD.org> X-Sender: crees@FreeBSD.org User-Agent: Roundcube Webmail/1.3.7 X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: B5360144D7.A8AA5 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@freebsd.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0210.5CAB07DB.007C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=P4AUeBIu c=1 sm=1 tr=0 a=i0HMBnJGy7D3/NFKO8d8XA==:117 a=i0HMBnJGy7D3/NFKO8d8XA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=oexKYjalfGEA:10 a=7Qk2ozbKAAAA:8 a=ypVJL4-jAAAA:8 a=s1G7sxBSAAAA:20 a=wW0svjmTV1EgS_fDcN4A:9 a=CjuIK1q_8ugA:10 a=1lyxoWkJIXJV6VJUPhuM:22 a=khIbc0fXALFIcTpOSxgJ:22 Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 2362E8E6A2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:33 -0000 X-Original-Date: Mon, 08 Apr 2019 09:28:45 +0100 X-List-Received-Date: Tue, 03 Sep 2019 14:06:33 -0000 On 2019-04-08 08:57, Oliver Pinter wrote: > On Monday, April 8, 2019, Warner Losh wrote: > >> >> >> On Sun, Apr 7, 2019, 3:16 PM Oliver Pinter >> >> wrote: >> >>> Please revert this patch. If I'm not wrong, this will break the >>> freebsd-version command's generation or output. >>> >> >> You are going to need to be a lot more specific about this. It makes >> no >> sense to me at all how any of this could break that. The code is >> identical >> logically and produces the same result. >> > > Now I double checked, it may work, but I remembered to this "black > magic" : > https://github.com/freebsd/freebsd/blob/master/bin/freebsd-version/Makefile > Given it will evaluate to BRANCH=${BRANCH_OVERRIDE:-CURRENT} which unless you set BRANCH_OVERRIDE, then it will still work no problem. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.