From owner-cvs-all Mon Dec 9 14: 4:10 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68A5B37B401 for ; Mon, 9 Dec 2002 14:04:09 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A07CA43ED1 for ; Mon, 9 Dec 2002 14:04:08 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 25745 invoked by uid 1000); 9 Dec 2002 22:04:09 -0000 Date: Mon, 9 Dec 2002 14:04:09 -0800 (PST) From: Nate Lawson To: Ian Dowse Cc: Josef Karthauser , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ohci.c In-Reply-To: <200212092048.aa11342@salmon.maths.tcd.ie> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 9 Dec 2002, Ian Dowse wrote: > In message <20021209202103.GA658@genius.tao.org.uk>, Josef Karthauser writes: > >On Mon, Dec 09, 2002 at 11:58:09AM -0800, Nate Lawson wrote: > >> On Sun, 8 Dec 2002, Josef Karthauser wrote: > >> > MFNetBSD: (partial 1.133) > >> > - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible > >> > race > >> > condition. > >> > Approved by: re (rwatson) > >> > >> Wouldn't it be better to use a mtx or tsleep/wakeup? A delay leaves the > >> race, only making it non-deterministic. > > >Probably, got a patch :)? > > I haven't looked at the code, but I suspect it is to avoid a race > with the USB hardware, since each usb frame lasts for 1ms. If that's the case then, my comment is not needed. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message