From owner-svn-src-all@freebsd.org  Sat May 11 14:45:23 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A35DC159EF58
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Sat, 11 May 2019 14:45:23 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 21A4C8B7B7
 for <svn-src-all@freebsd.org>; Sat, 11 May 2019 14:45:22 +0000 (UTC)
 (envelope-from ian@freebsd.org)
ARC-Seal: i=1; a=rsa-sha256; t=1557585913; cv=none;
 d=outbound.mailhop.org; s=arc-outbound20181012;
 b=bSquJz+7JfmvVY1X/4meL2iaqRCh6a6tM3RH0mcC0pXH3qCpVqHtDkEqYSG6TLl0aAqSnpI+GTB2c
 L4iG6xL2LkNPcK3CAseEaoNBWbrNKkbAgTnHCbZM1+RnN1I6UrbmbzJhZ7iEpwDNS9hLV9iAiDjCJo
 X5aK8dhZMyz3m0F+pIu4tqyxwaIC2iomF2FQaafOLcLm2MXDa2VryNsIiTZ30/j0JskUe0HtK1t2kA
 rG+cocGKVVtSN1pIAOiu3abwLN4t38A+EnfLXzFfkspB7Z/GUARO1OWR2/b80I5MIne6C7SZIZHsjT
 Sli2tjDQV+X8zp3i7ZsAQQLyxMmpsQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=outbound.mailhop.org; s=arc-outbound20181012;
 h=content-transfer-encoding:mime-version:content-type:references:in-reply-to:
 date:cc:to:from:subject:message-id:dkim-signature:from;
 bh=fRGwvz4oLq743QGqvXY2PT8tDUouh0XN1g63/lmM4+U=;
 b=elGTjj7J5979rTzezAPghccLAuGF45GwzhI7/ECns/V3lhqpnJrT2lpzyySPAs5TUQxE66Lc9qXrr
 sPQ4ibMbmxSrVtT1/ILySVVXIzUT326DpI05JaXXtWYh8juD76bqm0l11qsTLlFckc8569I31OSWWw
 GvkwY/4wbg2qVPyviKg8Y5LqS+L1vI6j7zt1+ljRlc9LwYUj5Hx5BcUi0w427I+OH8D6GfrWGkq/Ft
 kZbTuBLXrvJKM8c7qbjxsyhCw0TsvAYllWjjPDcwaAgcLvTxYh9SyJt8/FdJ8QAdYJ5XS4hvv1/C8K
 tuFKa9L7Xl7aD080Lexl7EDF42KbmFA==
ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org;
 spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60;
 dmarc=none header.from=freebsd.org;
 arc=none header.oldest-pass=0;
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=outbound.mailhop.org; s=dkim-high;
 h=content-transfer-encoding:mime-version:content-type:references:in-reply-to:
 date:cc:to:from:subject:message-id:from;
 bh=fRGwvz4oLq743QGqvXY2PT8tDUouh0XN1g63/lmM4+U=;
 b=oxvm1UCJewkxYLcT+22asJyJPUoyt+meMHam/+iP2U9mbGktNl7ZUqIb6Vuhz/kOoQ0nXCCYl6I7l
 QRNfEiDpq0T7Ru6pktyPoJaVhc19RnErTPBV/lA0wIb6A+JBFZOTbfJV+iGHVeDsrcAqhTK4pmk2Xh
 bmmujqjPbm8KZt2pxyrj3dp3NEbOz+o3g5162rMTYLYeeTb4BT1AHoYa1vNlod/83ovtnpRKR1NLbL
 UAjVVg+dnUrVYA2ulhAHDvm/e6JX/NfB/tF3hHoio+fXm9Jc6KuBmd6Vz3Vw+mHx4YHK6/il7kREVy
 J3czjEz1qInGb3jtplpU4ujyc+bjkKQ==
X-MHO-RoutePath: aGlwcGll
X-MHO-User: 5e6378b8-73fb-11e9-803c-31925da7267c
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound2.eu.mailhop.org (Halon) with ESMTPSA
 id 5e6378b8-73fb-11e9-803c-31925da7267c;
 Sat, 11 May 2019 14:45:10 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id x4BEj6Bf054991;
 Sat, 11 May 2019 08:45:06 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <82d76aafd3c93bc2ad2d0e04a761e2628ff1e257.camel@freebsd.org>
Subject: Re: svn commit: r347477 - head/sys/kern
From: Ian Lepore <ian@freebsd.org>
To: Doug Moore <unkadoug@gmail.com>, Cy Schubert <Cy.Schubert@cschubert.com>,
 Doug Moore <dougm@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Sat, 11 May 2019 08:45:06 -0600
In-Reply-To: <a5861276-9954-9185-fa75-ee0df8c3576e@gmail.com>
References: <201905110447.x4B4lqeh031565@slippy.cwsent.com>
 <a5861276-9954-9185-fa75-ee0df8c3576e@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 21A4C8B7B7
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.98 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.98)[-0.984,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2019 14:45:23 -0000

On Fri, 2019-05-10 at 23:57 -0500, Doug Moore wrote:
> With mentor approval, I commit r347469.  I start getting email about
> jenkins failure to build for several architectures on account of the
> _Generic() construct I introduced in that change.
> 
> I whip up a patch to undo that part of r347469, and ask for mentor
> approval.  Meanwhile, mentor authorizes me in email to revert
> r347469.
> 
> I try apply applying the fix-patch, and get email that it was
> rejected
> for lack of reviewer.  In retrospect, it seems to have been committed
> anyway as r347472.
> 
> Thinking that things are still broken, I do what my mentor pre-
> approved
> earlier and revert back to before r347469.  A patch to redo r347469,
> without _Generic(), awaits mentor approval.
> 
> I realize that breaking the build and then committing without mentor
> approval in my first week as committer isn't a good beginning.  
> Sorry
> about that.
> 
> At least I have no social media presence, so there's that.
> 
> Doug Moore
> 
> 

The important point is that the commit message should have said why. 
It doesn't have to be a whole novel, just something like "because
_Generic() isn't supported on all platforms" would've been good.

In general, for every commit, I ask myself "If someone 3 years from now
is debugging a problem and they're looking at the changes that have
happened to this code over time, will my commit message be helpful to
that process?"  Very often in that situation, what the person needs to
know isn't "what changed" so much as "why did this change happen?"

-- Ian


> On 5/10/19 11:47 PM, Cy Schubert wrote:
> > In message <201905110213.x4B2Dq9U088622@repo.freebsd.org>, Doug
> > Moore 
> > writes:
> > > Author: dougm
> > > Date: Sat May 11 02:13:52 2019
> > > New Revision: 347477
> > > URL: https://svnweb.freebsd.org/changeset/base/347477
> > > 
> > > Log:
> > >   Revert r347469.
> > 
> > Why?
> > 
> > >   
> > >   Approved by: kib (mentor)
> > > 
> > > Modified:
> > >   head/sys/kern/subr_blist.c
> > > 
> 
> 
>