From owner-svn-ports-all@FreeBSD.ORG Wed Feb 5 18:27:14 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A5D36A3D; Wed, 5 Feb 2014 18:27:14 +0000 (UTC) Received: from redundancy.redundancy.org (redundancy.redundancy.org [IPv6:2607:f2f8:a9c4::2]) by mx1.freebsd.org (Postfix) with ESMTP id 8BA0E18A6; Wed, 5 Feb 2014 18:27:14 +0000 (UTC) Received: by redundancy.redundancy.org (Postfix, from userid 1001) id D759D40E85B; Wed, 5 Feb 2014 10:27:13 -0800 (PST) Date: Wed, 5 Feb 2014 10:27:13 -0800 From: David Thiel To: marino@freebsd.org Subject: Re: svn commit: r342592 - head/dns/djbdns Message-ID: <20140205182713.GG55007@redundancy.redundancy.org> References: <201402041915.s14JFidj013872@svn.freebsd.org> <52F20239.7040901@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52F20239.7040901@marino.st> X-OpenPGP-Key-fingerprint: 482A 8C46 C844 7E7C 8CBC 2313 96EE BEE5 1F4B CA13 X-OpenPGP-Key-available: http://redundancy.redundancy.org/lx.gpg X-Face: %H~{$1~NOw1y#%mM6{|4:/ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2014 18:27:14 -0000 On 02/05, John Marino wrote: > On 2/4/2014 20:15, David Thiel wrote: > > Author: lx > > Date: Tue Feb 4 19:15:43 2014 > > New Revision: 342592 > > URL: http://svnweb.freebsd.org/changeset/ports/342592 > > QAT: https://qat.redports.org/buildarchive/r342592/ > > > > Log: > > Remove STAGE support, it screws up the run scripts. > > > > PR: 184949 > > Submitted by: issue reported by DrTebi > > > > Stage doesn't change install locations so "run scripts" shouldn't be > affected. Therefore I assume this comment really refers to some kind of > build/install scripts. It's not an issue of install locations. "run" scripts refers to the scripts generated by dnscache-conf and tinydns-conf (entitled "run"), which are then put into the service directory and launched by daemontools/runit. It needed to be reverted, as this completely broke the port, having the launch scripts attempt to run binaries out of the stage dir, which had already bitten someone. Given djbdns' rather exotic build process, getting those tools to generate the correct scripts while still staging properly will take enough time that I'd rather have the port functioning while I figure it out.