From owner-freebsd-current@FreeBSD.ORG  Tue Mar 15 20:31:21 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F1C916A4CE
	for <freebsd-current@freebsd.org>;
	Tue, 15 Mar 2005 20:31:21 +0000 (GMT)
Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5FFF043D53
	for <freebsd-current@freebsd.org>;
	Tue, 15 Mar 2005 20:31:20 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from gothmog.gr (patr530-a180.otenet.gr [212.205.215.180])
	j2FKUvWu022544;	Tue, 15 Mar 2005 22:30:58 +0200
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.13.3/8.13.3) with ESMTP id j2FKVE8o001687;
	Tue, 15 Mar 2005 22:31:14 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from giorgos@localhost)
	by gothmog.gr (8.13.3/8.13.3/Submit) id j2FKVEZZ001686;
	Tue, 15 Mar 2005 22:31:14 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Tue, 15 Mar 2005 22:31:14 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: Jose M Rodriguez <josemi@freebsd.jazztel.es>
Message-ID: <20050315203114.GB1558@gothmog.gr>
References: <200503142306.54642.freebsd@redesjm.local>
	<20050315062548.GA42826@gothmog.gr> <200503152058.16299.freebsd@redesjm.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503152058.16299.freebsd@redesjm.local>
cc: freebsd-current@freebsd.org
Subject: Re: rcNG changes/aditions
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2005 20:31:21 -0000

On 2005-03-15 20:58, Jose M Rodriguez <josemi@freebsd.jazztel.es> wrote:
> El Martes, 15 de Marzo de 2005 07:25, Giorgos Keramidas escribi?:
> > On 2005-03-14 23:06, Jose M Rodriguez <josemi@freebsd.jazztel.es> wrote:
> > > update to PR conf/75137 (sound modules): I rework this adding
> > > support for preloaded modules to /etc/rc.subr
> > >
> > > +					# try to load ${name}_modules
> > > +					#
> > > +			eval "_modules=\$${name}_modules"
> > > +			if [ -n "${_modules}" ]; then
> > > +				debug "run_rc_command: kldload ${_modules}."
> > > +				eval "preload_modules ${_modules}"
> > > +				_return=$?
> > > +				[ $_return -ne 0 ] && [ -z "$rc_force" ] &&
> > > +				    return 1
> > > +			fi
> >
> > What happens if some of the modules are already loaded and rc_force
> > is not set?
>
> preload_modules test if the module is loaded before trying to load.   It
> only load what is not loaded before.  I'm not sure if the logic is 100%
> safe, but I tested this case.

I must have missed this part.  Thanks the clarification :-)