From owner-freebsd-current@FreeBSD.ORG Tue Jun 9 07:21:05 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4B2F106567B; Tue, 9 Jun 2009 07:21:05 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 75FA28FC0A; Tue, 9 Jun 2009 07:21:05 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 7EF935C025; Tue, 9 Jun 2009 15:21:04 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 0300555CDB97; Tue, 9 Jun 2009 15:21:04 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id er3Xzu7Du-pZ; Tue, 9 Jun 2009 15:20:12 +0800 (CST) Received: from charlie.delphij.net (c-67-188-2-183.hsd1.ca.comcast.net [67.188.2.183]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 37E9355CDB93; Tue, 9 Jun 2009 15:20:04 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=T7uN/N1yueOOJuD3CcGAwtzbzlxltMU9T8l0p3Nl6iWcvGV5tbr2OE12ILFvQRlfe PgL3plWJDJhrS6y+cuHIw== Message-ID: <4A2E0D12.40101@delphij.net> Date: Tue, 09 Jun 2009 00:19:46 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.21 (X11/20090408) MIME-Version: 1.0 To: Danny Braniss References: <20090608224516.547F17302F@freebsd-current.sentex.ca> <4A2DA390.3090704@delphij.net> In-Reply-To: X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: d@delphij.net, Hiroki Sato , rea-fbsd@codelabs.ru, FreeBSD Current , net@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sparc64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 07:21:06 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Danny Braniss wrote: >> Xin, good day. >> >> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: >>> The attached patch should fix this, any objections? >> Yes, you missed negation operator in the copyin check. The issue >> was already fixed by hrs@ two hours ago: >> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 > sorry to barge in, but: > if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) > is not clear, > if ((options & ~GIF_FULLOPTS) == 0) > seems to be less offuscated or I'm missing something? Yes this looks like the usually used idiom (perhaps more efficient anyway)... I just kept the style consistent with the old code. Hiroki-san, could you have a look at this and consider if we should use this idiom? Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkouDRIACgkQi+vbBBjt66A1vACggjZwN3xCIHhfsEj141tAqqqX gdcAn0XM9BDHIhpWGct861T43SlmtQyv =ozhg -----END PGP SIGNATURE-----