From owner-cvs-src@FreeBSD.ORG  Tue Feb  8 10:39:13 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 833D816A4CE; Tue,  8 Feb 2005 10:39:13 +0000 (GMT)
Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 49A5543D48; Tue,  8 Feb 2005 10:39:13 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by cyrus.watson.org (Postfix) with SMTP id 8178746B2E;
	Tue,  8 Feb 2005 05:39:12 -0500 (EST)
Date: Tue, 8 Feb 2005 10:38:12 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Scott Long <scottl@FreeBSD.org>
In-Reply-To: <200502080343.j183h2Nt041950@repoman.freebsd.org>
Message-ID: <Pine.NEB.3.96L.1050208103744.95767D-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Feb 2005 10:39:13 -0000

On Tue, 8 Feb 2005, Scott Long wrote:

>   Fix crashdumps on twe.  The twe_immediate_request() path was not only
>   copying data to a temporary buffer before the I/O, but also copying that
>   temporary buffer back to the original data location after the I/O.  When
>   you're dumping kernel heap and stack and protected pages, this is very
>   very bad.
>   
>   A belated thanks to Robert Watson for donating hardware for this (and future)
>   work.
>   
>   MFC after: 3 days

Wonderful, thanks!  I and the rest of the 3ware-consuming world will
appreciate this much :-).

Robert N M Watson