From owner-cvs-src@FreeBSD.ORG Fri Jan 19 22:41:14 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1121A16A401; Fri, 19 Jan 2007 22:41:14 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id B193613C45B; Fri, 19 Jan 2007 22:41:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0JMfBKt074898; Fri, 19 Jan 2007 17:41:11 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Fri, 19 Jan 2007 17:41:08 -0500 User-Agent: KMail/1.9.4 References: <200701192237.l0JMbqNI009192@repoman.freebsd.org> In-Reply-To: <200701192237.l0JMbqNI009192@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701191741.08659.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Fri, 19 Jan 2007 17:41:11 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2466/Thu Jan 18 18:49:11 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/aic7xxx aic79xx.h aic79xx_pci.c src/sys/dev/pci pcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2007 22:41:14 -0000 On Friday 19 January 2007 17:37, John Baldwin wrote: > jhb 2007-01-19 22:37:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/aic7xxx aic79xx.h aic79xx_pci.c > sys/dev/pci pcireg.h > Log: > - Change the PCI-X registers constants to be relative to the PCI-X PCI > capability rather than hardcoded offsets for a particular card. While > I'm here, expand the constants some. > - Change the ahd(4) driver to use pci_find_extcap() to locate the PCI-X > capability to keep up with the first change. > > Reviewed by: scottl, gibbs (earlier version) Note that in Justin's defense, we didn't have a pci_find_extcap() function back when he added these constants, so he didn't have much of a choice other than hardcoding them. -- John Baldwin