From owner-cvs-all Tue Sep 28 7:48: 4 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id B571B154AD; Tue, 28 Sep 1999 07:47:36 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id ED9AF1CBF; Tue, 28 Sep 1999 22:47:34 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.0.2 2/24/98 To: Pierre Beyssac Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket2.c In-reply-to: Your message of "Tue, 28 Sep 1999 05:59:18 MST." <199909281259.FAA06641@freefall.freebsd.org> Date: Tue, 28 Sep 1999 22:47:34 +0800 From: Peter Wemm Message-Id: <19990928144734.ED9AF1CBF@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Pierre Beyssac wrote: > pb 1999/09/28 05:59:18 PDT > > Modified files: > sys/kern uipc_socket2.c > Log: > In sbflush(), don't exit the while loop too early: this can cause > an empty mbuf to stay in the queue, then causing a needless panic > because sb_cc == 0 and sb_mbcnt != 0. > > But we still need to panic rather than endlessly looping if, for > some reason, sb_cc == 0 and there are non-empty mbufs in the queue. Aha!! This sounds an awful lot like a bug I was seeing while using the if_pn driver in certain circumstances... Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message