From owner-freebsd-current@FreeBSD.ORG  Wed Dec 14 17:11:27 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0D85E16A41F
	for <current@freebsd.org>; Wed, 14 Dec 2005 17:11:27 +0000 (GMT)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8CCE743D68
	for <current@freebsd.org>; Wed, 14 Dec 2005 17:11:22 +0000 (GMT)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.13.4/8.13.4) with ESMTP id jBEHAlwI033456;
	Wed, 14 Dec 2005 09:10:47 -0800 (PST)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.13.4/8.13.4/Submit) id jBEHAdZ3033442;
	Wed, 14 Dec 2005 09:10:39 -0800 (PST)
Date: Wed, 14 Dec 2005 09:10:39 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200512141710.jBEHAdZ3033442@apollo.backplane.com>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>,
	FreeBSD current mailing list <current@freebsd.org>
References: <20051209175607.C23668@maildrop.int.zabbadoz.net>
	<20051210125221.M23668@maildrop.int.zabbadoz.net>
	<200512130031.jBD0VXih011394@apollo.backplane.com>
Cc: 
Subject: Re: nve(4) patch - please test!
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2005 17:11:27 -0000

    In addition to moving the nv_setmulti() and nv_ifmedia_upd() calls
    to a slightly different place in DFly (after pfnInit and before pfnStart),
    I also noticed that pfnStop() seems to take a flags argument which the
    header files define AFFECT_RECEIVER and AFFECT_TRANSMITTER for,
    but both our codes have been calling pfnStop() with a flags argument of
    0.

    I don't know if adding the flags has any effect but it doesn't seem to
    make things worse.  If pfnStop() isn't actually stopping the hardware
    due to incorrect flags then all sorts of bad things can happen.

						-Matt