Date: Wed, 29 Apr 2015 17:53:50 +0000 From: "zbb (Zbigniew Bodek)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support Message-ID: <57cfb3aef0ec8402a5d336a098c06ebe@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org> References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
zbb added inline comments.
INLINE COMMENTS
sys/arm64/arm64/gic_v3.c:160 From style(9):
No braces (`{' and `}') are used for control statements with zero or only a single statement unless that statement is more than a single line in which case they are permitted.
sys/arm64/arm64/gic_v3.c:255 This is the same "32" as in "uint32_t".
I can see a certain amount of exaggeration to define things. I don't think using
```
sizeof(uint32_t) * NBBY
```
looks better here.
sys/arm64/arm64/gic_v3.c:265 This may be more reasonable
sys/arm64/arm64/gic_v3.c:351 yes, yes READ_SPECIALREG
sys/arm64/arm64/gic_v3.c:438 This can be changed to FIRST_SPI indeed.
sys/arm64/arm64/gic_v3_reg.h:108 Scroll down to locore.S please
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D2377
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57cfb3aef0ec8402a5d336a098c06ebe>