Date: Thu, 16 Jan 2020 17:31:27 -0600 From: Eric van Gyzen <eric@vangyzen.net> To: davidcs@FreeBSD.org, freebsd-net@freebsd.org Subject: Strange logic in r336438 Message-ID: <c2fed140-f8a8-8173-9d64-b8b4be274334@vangyzen.net>
next in thread | raw e-mail | index | archive | help
I was just reviewing r336438: https://svnweb.freebsd.org/base?view=revision&revision=336438 In bxe_interrupt_detach(), the nested loops over sc->num_queues don't look right. We drain the taskqueues for queue 0, but then free the taskqueues for queues 1-N without draining them. Should the second loop come _after_ the first loop, instead of _in_ it? Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c2fed140-f8a8-8173-9d64-b8b4be274334>