From owner-freebsd-bugs@freebsd.org Thu Jan 19 19:22:35 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43978CB8812 for ; Thu, 19 Jan 2017 19:22:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1A7731FB1 for ; Thu, 19 Jan 2017 19:22:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0JJMYFJ032971 for ; Thu, 19 Jan 2017 19:22:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 216265] [patch] [mppc] invalid KASSERT prevent building kernel with NETGRAPH_MPPC_COMPRESSION and INVARIANTS Date: Thu, 19 Jan 2017 19:22:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ports@grosbein.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 19:22:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216265 Bug ID: 216265 Summary: [patch] [mppc] invalid KASSERT prevent building kernel with NETGRAPH_MPPC_COMPRESSION and INVARIANTS Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: ports@grosbein.net Keywords: patch Created attachment 179079 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179079&action= =3Dedit unbreak debugging kernel build Since 11.0-RELEASE, FreeBSD includes implementation of MMPC. Build of kernel configuration containing both of NETGRAPH_MPPC_COMPRESSION = and INVARIANTS fails: --- ng_mppc.o --- /home/src/sys/netgraph/ng_mppc.c:546:18: error: use of undeclared identifier 'MPPC_INVALID' KASSERT(rtn !=3D MPPC_INVALID, ("%s: invalid", __func__)); According to http://media.digikey.com/pdf/Data%20Sheets/EXAR%20PDFs/MPPC-C.= pdf return value MPPC_INVALID (zero) for "rtn" variable was supposed to denote invalid values for arguments srcCnt, dstCnt or flags passed to function MPPC_Compress(). Our implementation in sys/net/mppcc.c does not perform such validity checks and never returns zero value, so this KASSERT should be removed. Also, /* XXX NETGRAPH_MPPC_COMPRESSION isn't functional yet */ comment in t= he same file and some others are not valid anymore. This includes sys/conf/NOT= ES and sys/conf/options. Attached patch fixes this. --=20 You are receiving this mail because: You are the assignee for the bug.=